Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bold formatting is not working on entity annotations #210

Closed
cyberandy opened this issue Dec 9, 2015 · 6 comments
Closed

Bold formatting is not working on entity annotations #210

cyberandy opened this issue Dec 9, 2015 · 6 comments
Assignees

Comments

@cyberandy
Copy link
Member

Easy to be reproduced (and yes, we need a lot of testers like @matteoc):

  • Write a sentence containing at least one entity
  • Let the analysis run
  • Highlight few words including the entity being detected
  • Select the Bold

image

What happens is that - regardless of the selection of the entity (is it correct or not?) the editor CANNOT apply the Bold formatting to entities.

This is a strong limitation and shall be quickly fixed.

@cyberandy cyberandy changed the title Bold does NOT work on entity annotations Bold formatting is NOT work on entity annotations Dec 9, 2015
@cyberandy cyberandy changed the title Bold formatting is NOT work on entity annotations Bold formatting is NOT working on entity annotations Dec 9, 2015
@cyberandy cyberandy changed the title Bold formatting is NOT working on entity annotations Bold formatting is not working on entity annotations Dec 9, 2015
@mcolacino
Copy link
Contributor

Text annotations are not editable - contenteditable=false.
This behaviour was introduced to solve a previous bug (see issue #194).

A workaround here could be:

  1. remove the text annotation
  2. rewrite the text
  3. apply the bold and save
  4. disambiguate the text annotation.

@cyberandy
Copy link
Member Author

@mcolacino thx for your feedback here.
@matteoc this can be a quick solution to go live with the blog post while we think of any other possible alternatives. I've tested the workaround and it works just fine (see below).

image

@matteoc
Copy link
Contributor

matteoc commented Dec 10, 2015

Workaround is rather un-practical in my case as my whole article is full of bold phrases.
I temporarily disabled the wordlift plugin, published the post and then re-enabled it.
I have thus lost the entity but will restore once the bug is fixed.

@ziodave
Copy link
Member

ziodave commented Dec 10, 2015

IMHO we should rollback #194 to solve this issue, and think about another solution to #194.

@mcolacino
Copy link
Contributor

If you think it's so blocking (ad it seems so looking at @matteoc feedback) I agree with @ziodave

@mcolacino mcolacino self-assigned this Dec 13, 2015
@mcolacino
Copy link
Contributor

Fixed on 3.2.4

@mcolacino mcolacino reopened this Dec 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants