Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 7.2 compatibility #757

Closed
Stoyan0v opened this issue Jan 19, 2018 · 2 comments
Closed

PHP 7.2 compatibility #757

Stoyan0v opened this issue Jan 19, 2018 · 2 comments
Assignees
Milestone

Comments

@Stoyan0v
Copy link
Member

@Stoyan0v Stoyan0v commented Jan 19, 2018

We have to address all issues/notices that occur when running php7.2.

Currently count( ) on non array show notice.

There may have other issues too.

Stoyan0v added a commit that referenced this issue Feb 19, 2018
Stoyan0v added a commit that referenced this issue Feb 19, 2018
@ziodave ziodave added this to the 3.18 milestone Feb 26, 2018
ziodave added a commit that referenced this issue Feb 27, 2018
@ziodave ziodave added the merged label Feb 27, 2018
@ziodave ziodave closed this Mar 20, 2018
@ziodave ziodave modified the milestones: 3.18, 3.20.0 Mar 12, 2019
@ziodave

This comment has been minimized.

Copy link
Member

@ziodave ziodave commented Mar 12, 2019

Reopening for 3.20.0

@ziodave ziodave assigned ziodave and unassigned Stoyan0v Mar 12, 2019
@ziodave ziodave reopened this Mar 12, 2019
@ziodave

This comment has been minimized.

Copy link
Member

@ziodave ziodave commented Mar 12, 2019

~/.composer/vendor/bin/php7cc --except=vendor ./wordlift-plugin/src
Checked 260 files in 15.496 seconds
@ziodave ziodave closed this Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.