From 13f8fbc0d68ab5270d65b9f94773a68ac6b4faca Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Llu=C3=ADs=20Revilla?= Date: Thu, 30 Jan 2025 11:35:40 +0100 Subject: [PATCH 1/2] Add a new blocking note --- .github/workflows/build-check-install.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/build-check-install.yaml b/.github/workflows/build-check-install.yaml index 681b227f..efbd1519 100644 --- a/.github/workflows/build-check-install.yaml +++ b/.github/workflows/build-check-install.yaml @@ -63,6 +63,7 @@ on: checking for unstated dependencies in vignettes ... NOTE( )+\'.*\' import not declared from checking dependencies in R code ... NOTE( )+Namespace in Imports field not imported from checking installed package size ... NOTE( )+installed size is + Files named as vignettes but with no recognized vignette engine.+(Is a VignetteBuilder field missing?) required: false default: "" type: string From 4d90c715b6215349c3fde66807a884fd0ffd5662 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Llu=C3=ADs=20Revilla?= Date: Thu, 30 Jan 2025 11:45:22 +0100 Subject: [PATCH 2/2] Adding blocking note on more workflows --- .github/workflows/build-check-install.yaml | 2 +- .github/workflows/check.yaml.shared | 2 ++ .github/workflows/release.yaml.shared | 1 + 3 files changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build-check-install.yaml b/.github/workflows/build-check-install.yaml index efbd1519..72e649b0 100644 --- a/.github/workflows/build-check-install.yaml +++ b/.github/workflows/build-check-install.yaml @@ -63,7 +63,7 @@ on: checking for unstated dependencies in vignettes ... NOTE( )+\'.*\' import not declared from checking dependencies in R code ... NOTE( )+Namespace in Imports field not imported from checking installed package size ... NOTE( )+installed size is - Files named as vignettes but with no recognized vignette engine.+(Is a VignetteBuilder field missing?) + checking files in ‘vignettes’ ... NOTE( )+VignetteBuilder field missing required: false default: "" type: string diff --git a/.github/workflows/check.yaml.shared b/.github/workflows/check.yaml.shared index 091960ee..7dc5f8cf 100644 --- a/.github/workflows/check.yaml.shared +++ b/.github/workflows/check.yaml.shared @@ -38,6 +38,7 @@ jobs: checking Rd .usage sections .* NOTE checking for unstated dependencies in vignettes .* NOTE checking top-level files .* NOTE + checking files in ‘vignettes’ .* NOTE r-cmd-non-cran: name: R CMD Check (non-CRAN) 🧬 uses: insightsengineering/r.pkg.template/.github/workflows/build-check-install.yaml@main @@ -58,6 +59,7 @@ jobs: checking Rd .usage sections .* NOTE checking for unstated dependencies in vignettes .* NOTE checking top-level files .* NOTE + checking files in ‘vignettes’ .* NOTE coverage: name: Coverage 📔 uses: insightsengineering/r.pkg.template/.github/workflows/test-coverage.yaml@main diff --git a/.github/workflows/release.yaml.shared b/.github/workflows/release.yaml.shared index ffd6b68e..1d56a027 100644 --- a/.github/workflows/release.yaml.shared +++ b/.github/workflows/release.yaml.shared @@ -44,6 +44,7 @@ jobs: checking examples .* NOTE checking Rd line widths .* NOTE checking top-level files .* NOTE + checking files in ‘vignettes’ .* NOTE coverage: name: Coverage 📔 needs: [release, docs]