From dd13e02bf79dff8ea3ba5de106ee058765b66f39 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Llu=C3=ADs=20Revilla?= Date: Wed, 3 Dec 2025 15:15:19 +0100 Subject: [PATCH 1/3] Add initial testing depth too --- .github/workflows/build-check-install.yaml | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/.github/workflows/build-check-install.yaml b/.github/workflows/build-check-install.yaml index 9a4ef5c9..49ac903f 100644 --- a/.github/workflows/build-check-install.yaml +++ b/.github/workflows/build-check-install.yaml @@ -556,9 +556,9 @@ jobs: if [ -z "$td" ] then { echo "No TESTING_DEPTH default." - echo "Setting TESTING_DEPTH=5" - echo "TESTING_DEPTH=5" >> "$GITHUB_ENV" - td=5 + TESTING_DEPTH=5 + echo "Setting TESTING_DEPTH=${TESTING_DEPTH}" + echo "TESTING_DEPTH=${TESTING_DEPTH}" >> "$GITHUB_ENV" } fi echo "Commit msg is: ${commit_msg}" @@ -568,19 +568,18 @@ jobs: if [ -z "$test_all" ] then { echo "Last commit message forces to test everything." - echo "Using TESTING_DEPTH=$td" - echo "TESTING_DEPTH=$td" >> "$GITHUB_ENV" + echo "Using TESTING_DEPTH=${TESTING_DEPTH}" + echo "TESTING_DEPTH=${TESTING_DEPTH}" >> "$GITHUB_ENV" exit 0 } fi test_dir="tests/testthat/" - ALL_CHANGED_FILES="${ADDED} ${MODIFIED}" if [ -z "$ALL_CHANGED_FILES" ] then { echo "No R files affected: test everything." - echo Using "TESTING_DEPTH=$td" - echo "TESTING_DEPTH=$td" >> "$GITHUB_ENV" + echo Using "TESTING_DEPTH=${TESTING_DEPTH}" + echo "TESTING_DEPTH=${TESTING_DEPTH}" >> "$GITHUB_ENV" exit 0 } fi @@ -605,12 +604,12 @@ jobs: then { git restore $test_dir echo "Run all tests: Helpers modifications detected." - TESTING_DEPTH="$td"; + TESTING_DEPTH="${td}"; break; } else { sed -i 's/skip_if_too_deep(5)/skip_if_too_deep(3)/g' "$test_files" TESTING_DEPTH=3 - echo "TESTING_DEPTH=3" >> "$GITHUB_ENV" + echo "TESTING_DEPTH=${TESTING_DEPTH}" >> "$GITHUB_ENV" echo "Testing with shinytest2 only for $test_files"; } fi done From 45b667a8c8f0101c2aa3fae99224a0fde71085b4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Llu=C3=ADs=20Revilla?= Date: Wed, 3 Dec 2025 15:55:19 +0100 Subject: [PATCH 2/3] Add back variable deleted by mistake --- .github/workflows/build-check-install.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/build-check-install.yaml b/.github/workflows/build-check-install.yaml index 49ac903f..f71a806b 100644 --- a/.github/workflows/build-check-install.yaml +++ b/.github/workflows/build-check-install.yaml @@ -575,6 +575,7 @@ jobs: test_dir="tests/testthat/" + ALL_CHANGED_FILES="${ADDED} ${MODIFIED}" if [ -z "$ALL_CHANGED_FILES" ] then { echo "No R files affected: test everything." From 7eda7bceb37fd3b6ea29c2b361f817aea534f28a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Llu=C3=ADs=20Revilla=20Sancho?= Date: Wed, 3 Dec 2025 16:00:37 +0100 Subject: [PATCH 3/3] Shellcheck recommendation --- .github/workflows/build-check-install.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-check-install.yaml b/.github/workflows/build-check-install.yaml index f71a806b..4430bd4c 100644 --- a/.github/workflows/build-check-install.yaml +++ b/.github/workflows/build-check-install.yaml @@ -589,7 +589,7 @@ jobs: echo "Check for ${file}." # Skip files that were renamed or deleted - if [ ! -f $file ]; then { + if [ ! -f "$file" ]; then { echo "File not found!" continue } fi