Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

addition of tests for fixes to pagination #192

Merged
merged 4 commits into from
Jan 19, 2024
Merged

addition of tests for fixes to pagination #192

merged 4 commits into from
Jan 19, 2024

Conversation

Melkiades
Copy link
Contributor

@Melkiades Melkiades commented Jan 9, 2024 •
edited
Loading

Fixes #191 and #183. This should be the real fix for #155

@Melkiades Melkiades added bug Something isn't working sme labels Jan 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2024 •
edited
Loading

badge

Code Coverage Summary

Filename                 Stmts    Miss  Cover    Missing
---------------------  -------  ------  -------  ----------------------------------------------------
R/paginate_listing.R        47       1  97.87%   101
R/rlistings_methods.R      101      14  86.14%   39, 54, 58, 140-143, 146, 230-236
R/rlistings.R              166      25  84.94%   158-161, 164-167, 206-210, 377-380, 384-387, 420-423
TOTAL                      314      40  87.26%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: e016c17

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2024 •
edited
Loading

Unit Tests Summary

 1 files   4 suites   5s ⏱️
34 tests 27 ✅  7 💤 0 ❌
86 runs  75 ✅ 11 💤 0 ❌

Results for commit e016c17.

♻️ This comment has been updated with latest results.

@Melkiades Melkiades mentioned this pull request Jan 9, 2024
Merged
5 tasks
@Melkiades Melkiades mentioned this pull request Jan 10, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 10, 2024 •
edited
Loading

Unit Test Performance Difference

Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
paginate_listing 👶 $+0.15$ paginate_to_mpfs_works_with_wrapping_on_keycols
paginate_listing 👶 $+0.34$ paginate_to_mpfs_works_with_wrapping_on_keycols_when_doing_horizontal_pagination

Results for commit 77c8a9e

♻️ This comment has been updated with latest results.

shajoezhu
shajoezhu approved these changes Jan 19, 2024
View reviewed changes
Copy link
Collaborator

@shajoezhu shajoezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thanks @Melkiades

very nice new test examples

@Melkiades Melkiades mentioned this pull request Jan 19, 2024
Closed
Melkiades added a commit to insightsengineering/formatters that referenced this pull request Jan 19, 2024
@Melkiades @dependabot-preview
Fix of newlines in footers; towards fixing pagination for rlistings (#…
b7e455b 
…246)

Fixes the following issues

- [x] #243
- [x] #232
- [x] insightsengineering/rlistings#183
- [x] True fix for
insightsengineering/rlistings#155
- [x] insightsengineering/scda.test#99

To merge with insightsengineering/rlistings#192
(tests and misc) and
insightsengineering/rtables#813 (tests and
removed titles/footers newline handling)

---------

Signed-off-by: Davide Garolini <dgarolini@gmail.com>
Co-authored-by: 27856297+dependabot-preview[bot]@users.noreply.github.com <27856297+dependabot-preview[bot]@users.noreply.github.com>
@Melkiades Melkiades merged commit 8d17f14 into main Jan 19, 2024
23 checks passed
@Melkiades Melkiades deleted the 191_fix_pagination_w_nl@243_fix_nl_expansion@main branch January 19, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shajoezhu shajoezhu shajoezhu approved these changes

@edelarua edelarua Awaiting requested review from edelarua edelarua is a code owner

@ayogasekaram ayogasekaram Awaiting requested review from ayogasekaram ayogasekaram is a code owner

Assignees
No one assigned
Labels
bug Something isn't working sme
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Export_as_txt is failing for pagination, counting wrong for number of lines.
2 participants
@Melkiades @shajoezhu