From 72b26be01f7ae342095657fbecff1df5d7783c17 Mon Sep 17 00:00:00 2001 From: Pawel Rucki <12943682+pawelru@users.noreply.github.com> Date: Tue, 19 Nov 2024 19:00:38 +0100 Subject: [PATCH 1/7] vbump to 1.0.0 --- DESCRIPTION | 2 +- NEWS.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/DESCRIPTION b/DESCRIPTION index f7e3252..49faf1c 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -1,7 +1,7 @@ Type: Package Package: roxy.shinylive Title: A Roxygen2 Extension for Shinylive -Version: 0.0.0.9011 +Version: 1.0.0 Authors@R: c( person("Pawel Rucki", , , "pawel.rucki@roche.com", role = c("aut", "cre")), person("F. Hoffmann-La Roche AG", role = c("cph", "fnd")) diff --git a/NEWS.md b/NEWS.md index f457c31..9e2b59c 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,3 +1,3 @@ -# roxy.shinylive 0.0.0.9011 +# roxy.shinylive 1.0.0 - Initialize the package. From 03dac5e35c17142715a6c3689f982e2893651c52 Mon Sep 17 00:00:00 2001 From: Maciej Nasinski Date: Thu, 21 Nov 2024 09:22:58 +0100 Subject: [PATCH 2/7] Update README.md (#14) # Pull Request Signed-off-by: Maciej Nasinski --- README.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index a0ae0c1..9dfbd2a 100644 --- a/README.md +++ b/README.md @@ -2,7 +2,8 @@ ## Overview -This package provides a `roxygen2` extension that automatically takes the code from the `@examples` tag that follows and crate an URL to the shinylive service. During the documentation build, a new section is added to the function manual that contains aforementioned link as well as iframe to the application itself. +This package provides a `roxygen2` extension that automatically takes the code from the `@examples` tag that follows and create an URL to the shinylive service. +During the documentation build, a new section is added to the function manual that contains aforementioned link as well as iframe to the application itself. ## Install From a747938b7da1d010a7c96ec2d71be8debb6bd211 Mon Sep 17 00:00:00 2001 From: Pawel Rucki <12943682+pawelru@users.noreply.github.com> Date: Thu, 21 Nov 2024 11:27:36 +0100 Subject: [PATCH 3/7] updates --- .Rbuildignore | 41 +++++++++++++++++-------------- .pre-commit-config.yaml | 1 - DESCRIPTION | 8 +++--- README.md | 17 ++++++++++--- cran-comments.md | 54 +++++++++++++++++++++++++++++++++++++++++ inst/WORDLIST | 3 ++- 6 files changed, 97 insertions(+), 27 deletions(-) create mode 100644 cran-comments.md diff --git a/.Rbuildignore b/.Rbuildignore index 0ce030a..3c809e0 100644 --- a/.Rbuildignore +++ b/.Rbuildignore @@ -1,23 +1,28 @@ -^renv$ -^renv\.lock$ -CODE_OF_CONDUCT.md -SECURITY.md +# git +^\.git$ +^\.github$ +\.gitlab-ci\.yml$ + +# rstudio ^.*\.Rproj$ ^\.Rproj\.user$ -^_pkgdown\.yml$ -^vignettes/hello\.Rmd$ -^docs$ -^\.github$ -README.* -^\.lintr$ -^staged_dependencies\.yaml$ -coverage.* + +# dev tools ^\.pre-commit-config\.yaml$ -^codemeta\.json$ -init.sh -workflows.md -images -^pkgdown$ +^\.lintr$ +^\.covrignore$ ^.revdeprefs\.yaml$ ^revdep$ -^\.covrignore$ +^cran-comments\.md$ + +# pkgdown +^_pkgdown\.yml$ +pkgdown +^pkgdown$ + +# docs +^docs$ +LICENSE +^LICENSE\.md$ +SECURITY +^SECURITY\.md$ diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 7ee0c6d..b66af9a 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -11,7 +11,6 @@ repos: additional_dependencies: - glue - jsonlite - - roxygen2 - lzstring - roxygen2 - stringr diff --git a/DESCRIPTION b/DESCRIPTION index 49faf1c..bcc4e75 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -1,14 +1,14 @@ Type: Package Package: roxy.shinylive -Title: A Roxygen2 Extension for Shinylive +Title: A 'roxygen2' Extension for 'Shinylive' Version: 1.0.0 Authors@R: c( person("Pawel Rucki", , , "pawel.rucki@roche.com", role = c("aut", "cre")), person("F. Hoffmann-La Roche AG", role = c("cph", "fnd")) ) -Description: An extension for roxygen2 that allows to auto-create links to - shinylive from examples in the documentation. -License: Apache License 2.0 | file LICENSE +Description: An extension for 'roxygen2' to embed 'Shinylive' applications + in the package documentation. +License: Apache License 2.0 URL: https://github.com/insightsengineering/roxy.shinylive/ BugReports: https://github.com/insightsengineering/roxy.shinylive/issues Depends: diff --git a/README.md b/README.md index 9dfbd2a..04b246f 100644 --- a/README.md +++ b/README.md @@ -2,11 +2,22 @@ ## Overview -This package provides a `roxygen2` extension that automatically takes the code from the `@examples` tag that follows and create an URL to the shinylive service. +This package provides a `roxygen2` extension that automatically takes the code from the `@examples` tag and create an URL to the [shinylive.io](https://shinylive.io/) service. During the documentation build, a new section is added to the function manual that contains aforementioned link as well as iframe to the application itself. +### shinylive.io + +[shinylive.io](https://shinylive.io/) is a service that allows you to run [Shiny](https://shiny.posit.co/) applications entirely in the browser, without a dedicated server. It uses WebAssembly via [WebR](https://docs.r-wasm.org/webr/latest/). +It has a sharing feature that allows you to encode the application code in the URL. +This package does such encoding and returns the URL which can be used in variety of ways (from raw URL to iframe in function manual - see examples below). + ## Install +```r +install.packages("roxy.shinylive") +``` + +Alternatively, you might want to use the development version. ```r # install.packages("pak") pak::pak("insightsengineering/roxy.shinylive") @@ -50,12 +61,12 @@ Which would produce a following output in your documentation: \item{example-1}{ \href{https://shinylive.io/r/app/#code=...}{Open in Shinylive} \if{html}{\out{}} - \if{html}{\out{}} + \if{html}{\out{}} } \item{example-2}{ \href{https://shinylive.io/r/app/#code=...}{Open in Shinylive} \if{html}{\out{}} - \if{html}{\out{}} + \if{html}{\out{}} } ... } diff --git a/cran-comments.md b/cran-comments.md new file mode 100644 index 0000000..db690be --- /dev/null +++ b/cran-comments.md @@ -0,0 +1,54 @@ +## Comments + +#### 2024-11-21 + +Updates: +- Removed LICENSE file and its reference in the DESCRIPTION file. +- Used single quotes for package names etc. +- This package does not have any references to the academic publications hence no changes on that regard. +- Added README.md. + +Please let me know if I can provide any more information. + +Thank you, +Pawel + +#### 2024-11-20 + +Thanks, + +The LICENSE file is only needed if you have additional restrictions to +the license which you have not? In that case omit the file and its +reference in the DESCRIPTION file. + +Please always write package names, software names and API (application +programming interface) names in single quotes in title and description. +e.g: --> 'roxygen2', ... +Please note that package names are case sensitive. + +If there are references describing the methods in your package, please +add these in the description field of your DESCRIPTION file in the form +authors (year) +authors (year, ISBN:...) +or if those are not available: +with no space after 'doi:', 'https:' and angle brackets for +auto-linking. (If you want to add a title as well please put it in +quotes: "Title") + +Please fix and resubmit. + +Best, +Benjamin Altmann + +#### 2024-11-19 + +Initial submission. + +## R CMD check results + +0 errors | 0 warnings | 1 note + +─ checking CRAN incoming feasibility ... [2s/15s] NOTE (15.3s) + Maintainer: ‘Pawel Rucki ’ + + New submission diff --git a/inst/WORDLIST b/inst/WORDLIST index 3e45b60..d0216e6 100644 --- a/inst/WORDLIST +++ b/inst/WORDLIST @@ -1,8 +1,9 @@ -Roxygen Shinylive +WebAssembly WebR iframe installable +io roxy roxygen shinylive From fa5197003ab0c2bd1c9a97e4bb2b79c2a5792096 Mon Sep 17 00:00:00 2001 From: Pawel Rucki <12943682+pawelru@users.noreply.github.com> Date: Thu, 21 Nov 2024 11:30:37 +0100 Subject: [PATCH 4/7] lint --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index 04b246f..da11a0a 100644 --- a/README.md +++ b/README.md @@ -18,6 +18,7 @@ install.packages("roxy.shinylive") ``` Alternatively, you might want to use the development version. + ```r # install.packages("pak") pak::pak("insightsengineering/roxy.shinylive") From 3154d3cf88402900bcf8728760c332d65e8efcf2 Mon Sep 17 00:00:00 2001 From: Pawel Rucki <12943682+pawelru@users.noreply.github.com> Date: Thu, 21 Nov 2024 11:38:29 +0100 Subject: [PATCH 5/7] .markdownlintignore --- .Rbuildignore | 3 ++- .markdownlintignore | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) create mode 100644 .markdownlintignore diff --git a/.Rbuildignore b/.Rbuildignore index 3c809e0..a129681 100644 --- a/.Rbuildignore +++ b/.Rbuildignore @@ -11,8 +11,9 @@ ^\.pre-commit-config\.yaml$ ^\.lintr$ ^\.covrignore$ -^.revdeprefs\.yaml$ +^\.revdeprefs\.yaml$ ^revdep$ +^\.markdownlintignore$ ^cran-comments\.md$ # pkgdown diff --git a/.markdownlintignore b/.markdownlintignore new file mode 100644 index 0000000..40745f5 --- /dev/null +++ b/.markdownlintignore @@ -0,0 +1 @@ +^cran-comments\.md$ \ No newline at end of file From ee5df9803a6cba0fa2feb564a7215259d3190096 Mon Sep 17 00:00:00 2001 From: Pawel Rucki <12943682+pawelru@users.noreply.github.com> Date: Thu, 21 Nov 2024 11:50:33 +0100 Subject: [PATCH 6/7] md lint --- .markdownlintignore | 3 ++- README.md | 27 ++++++++++++++++++++++----- 2 files changed, 24 insertions(+), 6 deletions(-) diff --git a/.markdownlintignore b/.markdownlintignore index 40745f5..e00425b 100644 --- a/.markdownlintignore +++ b/.markdownlintignore @@ -1 +1,2 @@ -^cran-comments\.md$ \ No newline at end of file +cran-comments.md +SECURITY.md \ No newline at end of file diff --git a/README.md b/README.md index da11a0a..5638801 100644 --- a/README.md +++ b/README.md @@ -2,14 +2,23 @@ ## Overview -This package provides a `roxygen2` extension that automatically takes the code from the `@examples` tag and create an URL to the [shinylive.io](https://shinylive.io/) service. -During the documentation build, a new section is added to the function manual that contains aforementioned link as well as iframe to the application itself. +This package provides a `roxygen2` extension that automatically takes the code +from the `@examples` tag and create an URL to the +[shinylive.io](https://shinylive.io/) service. +During the documentation build, a new section is added to the function manual +that contains aforementioned link as well as iframe to the application itself. ### shinylive.io -[shinylive.io](https://shinylive.io/) is a service that allows you to run [Shiny](https://shiny.posit.co/) applications entirely in the browser, without a dedicated server. It uses WebAssembly via [WebR](https://docs.r-wasm.org/webr/latest/). -It has a sharing feature that allows you to encode the application code in the URL. -This package does such encoding and returns the URL which can be used in variety of ways (from raw URL to iframe in function manual - see examples below). +[shinylive.io](https://shinylive.io/) is a service that allows you to run +[Shiny](https://shiny.posit.co/) applications entirely in the browser, without +a dedicated server. It uses WebAssembly via +[WebR](https://docs.r-wasm.org/webr/latest/). + +It has a sharing feature that allows you to encode the application code in the +URL. This package does such encoding and returns the URL which can be used in +variety of ways (from raw URL to iframe in function manual - see examples +below). ## Install @@ -87,6 +96,8 @@ Suggests: Then in your vignette: + + ````Rmd ```{r shinylive_url, echo = FALSE, results = 'asis'} # extract the code from knitr code chunks by ID @@ -105,8 +116,14 @@ knitr::include_url(url, height = "800px") ``` ```` + + ![example of vignette](man/figures/vignette.gif) See the package documentation for more details. + + See the example implementation in the [`teal.modules.general`](https://insightsengineering.github.io/teal.modules.general/) or [`teal.modules.clinical`](https://insightsengineering.github.io/teal.modules.clinical/) packages. + + From d963008b9d7cc784944b677d55fb7bb88645bafd Mon Sep 17 00:00:00 2001 From: Pawel Rucki <12943682+pawelru@users.noreply.github.com> Date: Fri, 22 Nov 2024 11:12:03 +0100 Subject: [PATCH 7/7] Apply suggestions from code review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: André Veríssimo <211358+averissimo@users.noreply.github.com> Signed-off-by: Pawel Rucki <12943682+pawelru@users.noreply.github.com> --- README.md | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index 5638801..8ab4f87 100644 --- a/README.md +++ b/README.md @@ -6,17 +6,18 @@ This package provides a `roxygen2` extension that automatically takes the code from the `@examples` tag and create an URL to the [shinylive.io](https://shinylive.io/) service. During the documentation build, a new section is added to the function manual -that contains aforementioned link as well as iframe to the application itself. +that contains the aforementioned link as well as an iframe to the application itself. ### shinylive.io [shinylive.io](https://shinylive.io/) is a service that allows you to run [Shiny](https://shiny.posit.co/) applications entirely in the browser, without -a dedicated server. It uses WebAssembly via -[WebR](https://docs.r-wasm.org/webr/latest/). +a dedicated server. +It uses WebAssembly via [WebR](https://docs.r-wasm.org/webr/latest/). It has a sharing feature that allows you to encode the application code in the -URL. This package does such encoding and returns the URL which can be used in +URL. +This package does such encoding and returns the URL which can be used in variety of ways (from raw URL to iframe in function manual - see examples below).