Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

DOM testing to verify that React ref attributes are assigned correctly #26

Closed
insin opened this Issue Feb 26, 2014 · 2 comments

Comments

Projects
None yet
1 participant
Owner

insin commented Feb 26, 2014

Widgets add a ref attribute to form inputs corresponding to the input's id - this is currently being done in Widget.prototype.buildAttrs(), which might not be getting called for every input, particularly for widgets which generate multiple inputs.

We should also validate that refs are only added to form inputs.

There might be a need to implement an API to get a hold of all the ref attributes a widget will assign.

@insin insin added this to the 0.5.0 milestone Feb 26, 2014

Owner

insin commented Feb 28, 2014

Do we even need to add ref attributes? formData is there to walk the real DOM to get form values.

Presumably when implementing onChange validation for 0.6, we won't need refs then either, as the event target will tell us which field changed?

@insin insin removed this from the 0.5.0 milestone Mar 2, 2014

Owner

insin commented Apr 9, 2014

Refs are not needed internally, but can be set via BoundField#asWidget if people need them

@insin insin closed this Apr 9, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment