New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revoke button seems to be broken #177

Closed
plenka opened this Issue Dec 9, 2016 · 8 comments

Comments

Projects
None yet
9 participants
@plenka

plenka commented Dec 9, 2016

I'm trying to implement the cookie consent to always show the revoke button, but it seems to be broken. I've implemented the first example on https://cookieconsent.insites.com/documentation/javascript-api/, replacing the URLs of the JS and CSS files with the CDN URLs. The revoke button will show up directly after dismissing the consent notice, but after a page reload the revoke button doesn't show up.

I've tested this on macOS Sierra, Chrome 54.0.2840.98 and Safari 10.0.1.

@matejslo

This comment has been minimized.

matejslo commented Dec 14, 2016

I also have the same issue. Tested on Firefox 50.0.2 and Chrome 54.0.2840.99.

After reload revoke button disappears. After page reload the button DIV get a style display:none as follows: <div class="cc-revoke cc-bottom cc-animate cc-color-override-17377638 cc-active" style="display: none;">Cookies</div>.

My work around is to edit CSS:

.cc-revoke.cc-bottom {
display: block !important;
}

@l0calh05t

This comment has been minimized.

l0calh05t commented Jun 24, 2017

Can also confirm that this issue occurs on Microsoft Edge 40.15063.0.0 and Internet Explorer 11.0.43

There is a similar issue for v2 (closed with no information if it was fixed): #139

@ErikN72

This comment has been minimized.

ErikN72 commented Dec 28, 2017

I changed the code of cookieconsent.js in this part:

// opens the popup if no answer has been given
CookiePopup.prototype.autoOpen = function(options) {
//!this.hasAnswered() && this.options.enabled && this.open();
if (!this.hasAnswered() && this.options.enabled) {
this.open();
} else {
if (this.options.revokable)
{this.toggleRevokeButton(true);
}
}

};

Now it seems to work...
I would be interested in your opinion.

@Datajuristes

This comment has been minimized.

Datajuristes commented Jan 17, 2018

Thank you Erik, your code worked for me

@Jimmi08

This comment has been minimized.

Jimmi08 commented Feb 13, 2018

Thank you Erik, your code worked for me too.

@urbgimtam

This comment has been minimized.

urbgimtam commented May 23, 2018

Great work! This should be commited. Thanks

@reformed

This comment has been minimized.

reformed commented Jun 14, 2018

When is the next release that includes this fix?

@alexmorleyfinch

This comment has been minimized.

Contributor

alexmorleyfinch commented Jul 16, 2018

Very soon! Sorry it took so long. See here for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment