Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ WIP ] Attempted upgrade to yew 0.20 for mipsy-web, Run does not work #293

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SpanishPear
Copy link
Collaborator

@SpanishPear SpanishPear commented Sep 9, 2023

My (very long) attempt at upgrading mipsy-web to yew v0.20.
This upgrade works for yew 0.20 and yew-agent v0.2 , but the run behaviour will not work.

This is because the pattern we based the worker on is fundamentally opposed to the behaviour of yew-agent v2, so will require lots of rewriting. We could attempt to hack our way into it working in yew 0.20 but I don't see the benefit, and will abandon this until yewstack/yew#2773 has been merged, during which I'll redesign the worker methodology.

For more discussion on the patterns, checkout https://discord.com/channels/701068342760570933/1149300253820997653/1149300253820997653 in the yew discord

Most things work as is! Except the run button, as the automatic client -> worker -> client communication does not work without self-referencing data-structures.

@SpanishPear SpanishPear changed the title yew 0.20 upgrade but run will panic [ WIP ] Attempted upgrade to yew 0.20 for mipsy-web, Run does not work Sep 9, 2023
@SpanishPear SpanishPear marked this pull request as draft September 10, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant