New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inspec check and json to use vendored dependencies #1321

Merged
merged 3 commits into from Nov 29, 2016

Conversation

Projects
None yet
2 participants
@alexpop
Contributor

alexpop commented Nov 24, 2016

Fixes: #1316 by providing a cache directory. Otherwise copy_deps_into_cache is not called.

alexpop and others added some commits Nov 24, 2016

move default cache creation to profile implementation
Signed-off-by: Christoph Hartmann <chris@lollyrock.com>
@@ -53,10 +61,51 @@
out.stderr.must_equal ''
end
it 'ensure json command is not fetching remote profiles if vendored' do

This comment has been minimized.

@alexpop

alexpop Nov 29, 2016

Contributor

A good test for this would be to check that the vendored profile(ex: 01414bd307ea2f7d4dc8cd141085ba7ad61d4c3b2606d57b2dae987c1c3954cb.tar.gz was copied in the cache) instead of a remote one

@alexpop

alexpop Nov 29, 2016

Contributor

A good test for this would be to check that the vendored profile(ex: 01414bd307ea2f7d4dc8cd141085ba7ad61d4c3b2606d57b2dae987c1c3954cb.tar.gz was copied in the cache) instead of a remote one

This comment has been minimized.

@alexpop

alexpop Nov 29, 2016

Contributor

As in length is 1 and that profile is 01414bd307ea2f7d4dc8cd141085ba7ad61d4c3b2606d57b2dae987c1c3954cb.tar.gz

@alexpop

alexpop Nov 29, 2016

Contributor

As in length is 1 and that profile is 01414bd307ea2f7d4dc8cd141085ba7ad61d4c3b2606d57b2dae987c1c3954cb.tar.gz

Extend functional tests for vending based on feedback from @alexpop
Signed-off-by: Christoph Hartmann <chris@lollyrock.com>

@chris-rock chris-rock merged commit 45ef79b into master Nov 29, 2016

3 checks passed

DCO This commit has a DCO Signed-off-by
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chris-rock chris-rock deleted the ap/check-vendor-cache branch Nov 29, 2016

@chris-rock chris-rock removed the in progress label Nov 29, 2016

@chris-rock

This comment has been minimized.

Show comment
Hide comment
@chris-rock

chris-rock Nov 29, 2016

Member

Awesome. Thank you @alexpop

Member

chris-rock commented Nov 29, 2016

Awesome. Thank you @alexpop

@chris-rock chris-rock added this to the meta-profile support milestone Nov 29, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment