ensure we use the mock backend when we upload profiles #3370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christoph Hartmann <chris@lollyrock.com>
chris-rock
force-pushed
the
chris-rock/upload-with-mock
branch
from
93e2ce9
to
f0a343e
Compare
clintoncwolfe
approved these changes
Sep 7, 2018
There was a problem hiding this comment.
Refs #3373. Code seems reasonable, but currently untestable.
clintoncwolfe
added
Aspect: Performance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compliance upload has not used the mock backend. This is especially recognized due to long run-times on Windows if wmi resources have been used. We should never execute a profile against the local target for upload.
It also catches an issue where generated profiles are not deleted if they've been generated
Signed-off-by: Christoph Hartmann chris@lollyrock.com