New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to the functional helper run_inspec_process #3603

Merged
merged 6 commits into from Nov 16, 2018

Conversation

Projects
None yet
3 participants
@clintoncwolfe
Contributor

clintoncwolfe commented Nov 9, 2018

This PR adds features I keep dragging around with me from branch to branch. It only affects the functional test helper, so this is real "inside baseball" stuff.

It adds a run_inspec_helper method, similar to that available in the plugin test harness. Its main difference is that it can take a hash of options, and then later commits build on that to allow running with a tmpdir created, generating a temporary plugin file, and automatically processing JSON ourput.

clintoncwolfe added some commits Oct 12, 2018

Add run_inspec_process, with JSON handling, to functional helper
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
Add ability to run a plugin to functional helper
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
CWD fix for run_inspec_process
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
Add support for running a plugin within a functional test
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>

clintoncwolfe added some commits Nov 15, 2018

Move plugin functional helper code to main func helper file
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
FuncHelper: Do not send reporter or lock options if command is not exec
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
@jquick

jquick approved these changes Nov 16, 2018

Thanks @clintoncwolfe! Looks good.

@miah

miah approved these changes Nov 16, 2018

Great additions. Thanks @clintoncwolfe

@jquick jquick merged commit 35ad5d5 into master Nov 16, 2018

4 checks passed

DCO This commit has a DCO Signed-off-by
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
expeditor/config-validation Validated your Expeditor config file
Details

@jquick jquick deleted the cw/functional-test-helper-plugin branch Nov 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment