New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package: fix package detection on windows #3607

Merged
merged 4 commits into from Nov 27, 2018

Conversation

Projects
None yet
4 participants
@mhackethal
Contributor

mhackethal commented Nov 13, 2018

Update the windows package search regex.
According to issue #3361

Signed-off-by: mhackethal mh@it31.de

mhackethal added some commits Nov 13, 2018

Update package.rb to solve issue #3361
Update the windows package search regex.
According to issue #3361
Update package.rb
Fix trailing spaces
Signed-off-by: markus hackethal <mh@it31.de>
Update helper.rb
update sha for get-item-package. To fix the issue #3361
Signed-off-by: markus hackethal <mh@it31.de>

@clintoncwolfe clintoncwolfe changed the title from Update package.rb to solve issue #3361 to package: fix package detection on windows Nov 15, 2018

@jquick

jquick approved these changes Nov 26, 2018

Looks good, thanks @mhackethal

@jerryaldrichiii

Great catch @mhackethal

@jquick jquick merged commit b67236e into inspec:master Nov 27, 2018

4 checks passed

DCO This commit has a DCO Signed-off-by
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
expeditor/config-validation Validated your Expeditor config file
Details

@mhackethal mhackethal deleted the mhackethal:patch-2 branch Nov 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment