Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document additional usage of json resource #3737

Merged
merged 2 commits into from Jan 23, 2019
Merged

Conversation

webframp
Copy link
Contributor

The command and content usage seems to have been supported for some time, but is not included in the documentation.

ref:

The `command` and `content` usage seems to have been supported for some time, but is not included in the documentation.

ref:
* inspec#1271

Signed-off-by: Sean Escriva <sean.escriva@gmail.com>
@webframp
Copy link
Contributor Author

Force pushed to update the signoff for DCO, let me know if I missed anything here

Copy link
Contributor

@jerryaldrichiii jerryaldrichiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this @webframp! Just a few typos then we'll get it merged.

Also, congratulations on your first contribution. 😄

docs/resources/json.md.erb Outdated Show resolved Hide resolved
Copy link
Contributor

@jerryaldrichiii jerryaldrichiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, missed one on the other review.

docs/resources/json.md.erb Outdated Show resolved Hide resolved
Copy link
Contributor

@miah miah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @webframp! I think this is safe to merge after we fix up the typos.

Signed-off-by: Sean Escriva <sean.escriva@gmail.com>
@webframp
Copy link
Contributor Author

webframp commented Jan 23, 2019

Thanks for the review @miah and @jerryaldrichiii and @Vasu1105. Updated my branch

Copy link
Contributor

@jerryaldrichiii jerryaldrichiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @webframp.

@miah miah merged commit 0649612 into inspec:master Jan 23, 2019
@webframp webframp deleted the patch-1 branch January 23, 2019 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants