Add resource stubs so the resource loader will find all resources #4526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevendanna
reviewed
Sep 27, 2019
miah
approved these changes
Sep 27, 2019
…e code file for services Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
zenspider
force-pushed
the
cw/fix-resource-loader-by-name
branch
from
29845da
to
9a2d360
Compare
|
Code Climate has analyzed commit 9a2d360 and detected 0 issues on this pull request. View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#4365 introduced dynamic resource loading, which makes InSpec much faster, but it relies on there being a 1:1 relationship between resource files and resources, which is not quite true. Most notably, most service resources are combined in the
service.rbfile, which definesrunit_service,systemd_service, etc. Because these individual files did not exist, the loader failed to find them, and #4521 happens.This PR makes the simple approach of adding a stub file for each service that requires service.rb.
While in DRAFT, am currently looking for other resources that do the same thing.
Related Issue
Fixes #4521
There was manual testing done on this, before and after, using the control code listed on #4529 .
Types of changes
Checklist: