Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add suport for freebsd package resource #4789

Merged
merged 1 commit into from Dec 17, 2019

Conversation

fzipi
Copy link
Contributor

@fzipi fzipi commented Dec 16, 2019

Description

This PR adds support for testing using package resources in FreeBSD.

Related Issue

Created #4788.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New content (non-breaking change)
  • Breaking change (a content change which would break existing functionality or processes)

Checklist:

  • [ x ] I have read the CONTRIBUTING document.

@fzipi fzipi requested a review from a team as a code owner December 16, 2019 19:27
@ghost ghost requested review from clintoncwolfe and zenspider December 16, 2019 19:27
@chef-expeditor
Copy link
Contributor

Hello fzipi! Thanks for the pull request!

Here is what will happen next:

  1. Your PR will be reviewed by the maintainers.
  2. Possible Outcomes
    a. If everything looks good, one of them will approve it, and your PR will be merged.
    b. The maintainer may request follow-on work (e.g. code fix, linting, etc). We would encourage you to address this work in 2-3 business days to keep the conversation going and to get your contribution in sooner.
    c. Cases exist where a PR is neither aligned to Chef InSpec's product roadmap, or something the team can own or maintain long-term. In these cases, the maintainer will provide justification and close out the PR.

Thank you for contributing!

@zenspider
Copy link
Contributor

The failures on BK have nothing to do with your PR and everything to do with rubygems breaking things in the latest version. Ignore that for now. I have a PR coming shortly that should fix things. Rebasing against master once that goes in should clear this up.

@zenspider
Copy link
Contributor

Merged... Please rebase against master and force push.

Copy link
Contributor

@zenspider zenspider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit (not need to fix unless you want to). Needs a rebase against master for proper CI. After that goes green, this should be good to go.

lib/inspec/resources/package.rb Outdated Show resolved Hide resolved
Signed-off-by: Felipe Zipitria <fzipitria@perceptyx.com>
@zenspider zenspider merged commit 83f7504 into inspec:master Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants