Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows 7 EOL Docs Update #4841

Merged
merged 4 commits into from Jan 21, 2020
Merged

Windows 7 EOL Docs Update #4841

merged 4 commits into from Jan 21, 2020

Conversation

mjingle
Copy link
Contributor

@mjingle mjingle commented Jan 17, 2020 •
edited

Signed-off-by: Mary Jinglewski mjinglewski@chef.io

Description

With EOL for Windows 7 and Windows 2008 happening this month, related documentation needs updating.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New content (non-breaking change)
  • Breaking change (a content change which would break existing functionality or processes)

Checklist:

  • I have read the CONTRIBUTING document.

Windows 7 and Windows 2008 EOL Docs Update
5074bf5 
Signed-off-by: Mary Jinglewski <mjinglewski@chef.io>
@mjingle mjingle added the Aspect: Docs Write the Fine Manual label Jan 17, 2020
@mjingle mjingle requested a review from a team as a code owner January 17, 2020 21:35
@mjingle mjingle self-assigned this Jan 17, 2020
@ghost ghost requested review from clintoncwolfe and miah January 17, 2020 21:35
@chef-expeditor
Copy link
Contributor

Hello mjingle! Thanks for the pull request!

Here is what will happen next:

  1. Your PR will be reviewed by the maintainers.
  2. Possible Outcomes
    a. If everything looks good, one of them will approve it, and your PR will be merged.
    b. The maintainer may request follow-on work (e.g. code fix, linting, etc). We would encourage you to address this work in 2-3 business days to keep the conversation going and to get your contribution in sooner.
    c. Cases exist where a PR is neither aligned to Chef InSpec's product roadmap, or something the team can own or maintain long-term. In these cases, the maintainer will provide justification and close out the PR.

Thank you for contributing!

Correction for over compensation
cfd8445 
Signed-off-by: Mary Jinglewski <mjinglewski@chef.io>
mjingle
mjingle commented Jan 17, 2020
View reviewed changes
README.md
@@ -332,7 +332,6 @@ In addition, runtime support is provided for:
| Debian | 8, 9 | x86_64 |
| RHEL | 6, 7 | x86_64 |
| Ubuntu | 12.04+ | x86_64 |
| Windows | 7+ | x86_64 |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be changed to 8+ rather than removing this Windows row?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zenspider ^ ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would think so.

zenspider
zenspider reviewed Jan 17, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
clintoncwolfe
clintoncwolfe approved these changes Jan 21, 2020
View reviewed changes
Copy link
Contributor

@clintoncwolfe clintoncwolfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, let's add that 8+ back in and I think we're all set - thanks!

README.md
@@ -332,7 +332,6 @@ In addition, runtime support is provided for:
| Debian | 8, 9 | x86_64 |
| RHEL | 6, 7 | x86_64 |
| Ubuntu | 12.04+ | x86_64 |
| Windows | 7+ | x86_64 |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would think so.

Mary Jinglewski added 2 commits January 21, 2020 11:36
Additional Fix
15337b2 
Signed-off-by: Mary Jinglewski <mjinglewski@chef.io>
Spacing Issue Fix
5049975 
Signed-off-by: Mary Jinglewski <mjinglewski@chef.io>
@codeclimate
Copy link

codeclimate bot commented Jan 21, 2020

Code Climate has analyzed commit 5049975 and detected 0 issues on this pull request.

View more on Code Climate.

@zenspider zenspider merged commit 524e245 into master Jan 21, 2020
@chef-expeditor chef-expeditor bot deleted the mj/2008Fixes branch January 21, 2020 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zenspider zenspider zenspider approved these changes

@clintoncwolfe clintoncwolfe clintoncwolfe approved these changes

@miah miah Awaiting requested review from miah

Assignees

@mjingle mjingle

Labels
Aspect: Docs Write the Fine Manual
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mjingle @zenspider @clintoncwolfe