Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update installer license text #5073

Merged
merged 1 commit into from Jun 9, 2020
Merged

Update installer license text #5073

merged 1 commit into from Jun 9, 2020

Conversation

james-stocks
Copy link
Contributor

@james-stocks james-stocks commented Jun 4, 2020

Copied the correct license text over from chef/chef

Fixes 5066

Kicked off an adhoc build to test the installers from this branch: https://buildkite.com/chef/inspec-inspec-master-omnibus-adhoc/builds/140#eb343d2c-9fea-42da-adba-222c6bf0831a

Signed-off-by: James Stocks jstocks@chef.io

Aha! Link: https://chef.aha.io/features/SH-2160

Copy link
Contributor

@clintoncwolfe clintoncwolfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think correcting the license displayed in the GUI installer is absolutely the correct thing to do. I wish we had caught this last April.

I think we need to consider whether accepting the Personal-Use license in the GUI installer should also write the license-accepted marker file. If not, the user will be prompted again on first invocation, which is bad UX.

Second, is this the right license? For our commercial customers, my understanding is they are bound by a different, commercial agreement. Do we need to offer a choice between a personal use license and a commercial license? Do we need to validate the commercial license....?

Third, I'm pretty sure we need to have Legal review this before we make a change. We don't want to change to the wrong thing, and then have to change again, further eroding trust.

@james-stocks
Copy link
Contributor Author

@clintoncwolfe -

  1. This is a great idea. I imagine we can get Omnibus to do this for us, but I'd prefer to do it outside this PR.

  2. This is the same license included with chef/chef and I don't think omnibus supports offering multiple licenses.

  3. good idea to check with Legal, I have CC'ed you on a query with them.

Schwad
Schwad previously approved these changes Jun 5, 2020
Copy link
Contributor

@Schwad Schwad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll defer to y'alls judgment on the best ways to approach licensing but cheers for getting this updated, following legal check looks good to me 👍 <edit: approval removed>

@Schwad Schwad self-requested a review June 5, 2020 11:34
@Schwad Schwad dismissed their stale review June 5, 2020 11:36

Awaiting legal

Copied the correct license text over from chef/chef and updated latest date to May 14 2019

Fixes #5066

Signed-off-by: James Stocks <jstocks@chef.io>
@james-stocks
Copy link
Contributor Author

@clintoncwolfe I just had a call with Legal - they confirmed that the current text is correct

@james-stocks
Copy link
Contributor Author

@clintoncwolfe I've also tested the OSX and Windows installers from the ad-hoc build; license is definitely updated

@james-stocks james-stocks merged commit c54b734 into master Jun 9, 2020
@james-stocks james-stocks deleted the js/installer_license branch June 9, 2020 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants