Add Google API application info #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The current behavior is that requests are made with an unknown user-agent.
The new behavior is that the requests include
|
chris-rock
approved these changes
Nov 7, 2018
nathenharvey
force-pushed
the
gcp-useragent
branch
from
d0b5aaf
to
40940c8
Compare
* Set the `application_name` to `chef-inspec-train` * Set the `applicaiton_version` to the current version of train (`Train::VERSION`) Based on conversation with @chris-rock this is a more descriptive name for this applicaiton. Signed-off-by: Nathen Harvey <nathenharvey@google.com>
nathenharvey
force-pushed
the
gcp-useragent
branch
from
40940c8
to
e1ed12c
Compare
|
squashed the commits so it's a single commit merge when you're ready @chris-rock |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will help measure requests to the Google API that come from train.
Signed-off-by: Nathen Harvey nathenharvey@google.com