Permalink
Commits on Jul 11, 2017
  1. Improve and centralize socket engine event counters.

    rburchell committed Mar 22, 2017
    The write counters were close to useless because they were only
    incremented on a write "event" which is only triggered when writing
    would block.
    
    Read handling was a little more useful in that all reads must happen
    through the socket engine, so these were happening at the correct time,
    but we can clean this up by doing it in the SE itself rather than each
    platform port.
    
    This means that both read and write events are now easily and usefully
    defined as "a syscall of either read or write was attempted".
    
    We also count empty read and write events as being an event, because
    they still were an attempt to poll a socket in some way. This may help
    to identify "bad" code which is repeatedly trying to read a socket for
    some reason.
    
    Lastly, we check for failed read/write calls, and log them as an error
    event. A lot of the time, this is how sockets are determined as being
    disconnected (ie. at read/write time).
    
    While we're at it, split Update() in two to make the calls more
    self-describing. This has no real impact since only one call is made at
    a time anyway.
Commits on Nov 9, 2015
  1. inspircd: Don't list individual authors on startup.

    rburchell committed Nov 9, 2015
    We already keep track of this in /INFO, so point there instead.
  2. info: Move SaberUK to Core Developers.

    rburchell committed Sep 21, 2015
    Reflects reality, he's done a fair chunk of work. :)
  3. info: Reflect reality, and move everyone who hasn't committed since 2…

    rburchell committed Sep 21, 2015
    …010 to "Former Developers"
    
    Self-explanatory, I hope.
  4. info: Merge "Regular Contributors" and "Other Contributors" into "Act…

    rburchell committed Sep 21, 2015
    …ive Contributors"
    
    Neither of the two other titles were really informative, and this now gels with
    "Former Contributors".
  5. info: Remove searchirc.com (now defunct), change irc-junkie credits t…

    rburchell committed Sep 21, 2015
    …o Asmo.
    
    Asmo was the guy who deserves thanks, not the site, per-se.
  6. info: Move the early three of us to a "founding developers" section.

    rburchell committed Sep 21, 2015
    Reflecting the reality that we are of some kind of importance, even if we aren't
    really doing much nowdays except sipping cocktails on the beach.
  7. info: Move jackmcbarn from developers back to contributors.

    rburchell committed Sep 21, 2015
    His last contribution was moving his name here, which doesn't seem to quite gel.
Commits on Oct 4, 2014
  1. Revert "Fix an off-by-one on registration timeout handling."

    rburchell committed Oct 4, 2014
    This seemingly breaks (occasionally timing users out a second early), possibly
    due to rounding issues on time (User::age and Time() both return int, but a
    whole second is comprised of many ms).
    
    The root cause needs investigation, but we cannot leave a potentially breaking
    bug in the tree.
    
    This reverts commit 4414d64.
  2. Fix an off-by-one on registration timeout handling.

    rburchell committed Oct 4, 2014
    The use of > instead of >= here added a second onto the configured timeout.
    
    We won't be breaking any existing configuration, because users.h explicitly
    increases the limit if it's 0.
Commits on Jan 16, 2013
  1. Merge pull request #403 from SaberUK/insp20+wextra-fixes

    rburchell committed Jan 16, 2013
    Fix warning: "const type qualifier on return type has no effect".
Commits on Nov 29, 2012
  1. ldapauth: RAII returned ldap message.

    rburchell committed Nov 28, 2012
    This ensures it is always freed, and coincidentally fixes freeing in the case of
    LDAP errors.
  2. ldapauth: fix memory leak

    rburchell committed Nov 28, 2012
    ldap_get_dn() results need to be freed. Use a RAII wrapper to do this.
    
    Original code by Attila Molnar
  3. ldapauth: Allow setting virtual hosts on identification with m_ldapauth.

    rburchell committed Nov 28, 2012
    <ldapauth:host>, when set, will be applied to users identifying with ldapauth.
    The host can also take formatters from fields set on the DN of the user.
  4. ldapauth: Rework required attributes code to use only one exit path.

    rburchell committed Nov 28, 2012
    This makes the upcoming patch to add optional virtual host support cleaner.
Commits on Aug 13, 2012
  1. Merge pull request #251 from Shawn-Smith/insp20+extbanU

    rburchell committed Aug 13, 2012
    [2.0] Add ExtBan U to match only unregistered users
Commits on Jul 1, 2012
  1. Don't throw an exception if passed bad parameters to stringjoiner.

    rburchell committed Jul 1, 2012
    It's far too common to "misuse" this API by accidentally trying to use
    stringjoiner with an empty container, and fixing that is more or less adding
    boilerplate in every place we fix it.
    
    Instead, let's just return and not touch the string, and not throw.
    
    Done-with: Attila Molnar <attilamolnar@hush.com>
  2. Revert "users: introduce OnSetClientIP hook."

    rburchell committed Jul 1, 2012
    This reverts commit 5fd31ec.
Commits on Jun 29, 2012
  1. Merge pull request #238 from SaberUK/insp20-spelling-fix

    rburchell committed Jun 29, 2012
    [2.0] Spelling fix.
Commits on Jun 15, 2012
  1. Merge pull request #193 from attilamolnar/insp20+newlinefix

    rburchell committed Jun 15, 2012
    [2.0] Cut the ending \n from all lines in included (exec)files
Commits on Jun 1, 2012
  1. Merge pull request #179 from attilamolnar/insp20+desyncfix

    rburchell committed Jun 1, 2012
    [2.0] Fix desyncs caused by m_autoop and broken spanningtree routing logic
  2. Merge pull request #182 from attilamolnar/insp20+gnutlsfix

    rburchell committed Jun 1, 2012
    [2.0] Fix crash in m_ssl_gnutls destructor when dh_params wasn't inited
Commits on May 30, 2012
  1. Merge pull request #175 from attilamolnar/insp20+chopfix

    rburchell committed May 30, 2012
    [2.0] Fix last character being chopped off in included (exec)files
  2. Merge pull request #173 from Robby-/insp20-moddesc

    rburchell committed May 30, 2012
    [2.0] Module description updates
  3. Merge pull request #166 from Robby-/insp20-cfgcorrections

    rburchell committed May 30, 2012
    [2.0] Add more documentation about logging, aswell as make text, tab and space corrections to the configs.
  4. Merge pull request #159 from gholms/md5-memset-20

    rburchell committed May 30, 2012
    [2.0] md5: zero the whole MD5Context, not only part of it
  5. Merge pull request #163 from attilamolnar/insp20+silentjoinfix

    rburchell committed May 30, 2012
    [2.0] Don't send a MODE on join when the join was silenced by a module