Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Mode change string failing to parse on clients #1636
Mode change string failing to parse on clients.
The recent 3.0 update breaks the nicklist update on many IRC clients (Confirmed HexChat & have had it reported as affecting mIRC)
Reported upstream to hexchat (hexchat/hexchat#2335) and issue appears to be caused by the MODE change having the
Steps to reproduce the issue:
Describe the results you received:
Describe the results you expected:
Additional information you deem important (e.g. issue happens only occasionally):
Workaround of running a manual
This is a client issue (which is why HexChat have fixed it in Git) as the messages we send are entirely valid according to the formatting rules in part 2.3.1 of RFC 1459 (note two is of specific relevance here). If mIRC is also having problems parsing the messages we send then please report them to the developer.
This is also unfortunately not something we can really work around because of the changes in how we emit messages which were necessary for robust tag support. In order to work around these client bugs we would need to go through every single place that messages are sent and manually specify whether a message should be emitted with a
Contrary to some of the claims which have been made recently in #inspircd we could not just check if the final parameter of a message is empty or contains a space because the same broken parsers would choke on messages like
This isn't a difficult bug for client developers to fix (ircdocs even provides parser test vectors) so please ask them to fix it.
I got the same trouble, only with inspircd v3. Why you need client to get fixed, when they work well on other ircd? It's clearly due to something wrong into inpsircd v3.
On androirc same thing happen, but when you do /names or /list it's duplicate the nickname list and adding status to user, so you have @nick and nick into the nick list.. just duplication. with and without status.
And "you better code your clients to fix our mistake" or "it's a client issue" isn't a good answer, as it is not an issue on any other ircd (ircu [even from undernet!!], nafarious2, bahamut, ratbox, plexus, charybdis). I hope you don't think this is a viable way to promote inspircd v3.
Just because it happens to work with other IRC server implementations doesn't mean its not broken.
The parsing rules in RFC 1459 are very clear about how messages should be parsed and InspIRCd emits messages which are valid according to those rules. We can't work around this bug without a ton of effort and essentially reverting to the way messages were handled in v2 which isn't compatible with tags.
There's plenty of clients which actually follow the IRC specs. Maybe use one of those instead?