Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

IncreaseOSBuffers() in inspsocket.cpp assumedly does nothing #302

Open
blitmap opened this Issue · 1 comment

2 participants

@blitmap

http://www.kernel.org/doc/man-pages/online/pages/man7/tcp.7.html

Fourth paragraph states that increasing the send or receive buffer of a socket should be done before a listen() or connect(), which is not the case within BufferSocket::BeginConnect()

The call to IncreaseOSBuffers() should be made before ServerInstance->SE->Connect(), no?

ALSO, perhaps this shouldn't even be here, maybe remove IncreaseOSBuffers() altogether unless it can be done smartly? Supposedly it hasn't even been working all this time.

In debug runs, maybe the socket options set for the server sockets should be printed somewhere.

@attilamolnar

removed the no-op call in 2.0, milestone set to 2.2 for moving this inside the socketengine and making this actually work if we want it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.