-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
references: first commits #1330
Conversation
We'll use this in #1279 instead of the hardcoded dojson thing and also for moving holdingpen records into hep records without breaking the whole holdingpen :) |
I love this :) |
|
||
|
||
def _is_arxiv(obj): | ||
arxiv_test = obj.split() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is obj in this context? What does this line do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll add a comment. idutils
does not parse arXiv:2905.0001 [hep-th]
but only the first part. At least in references we have lots of strings including the category ([hep-th]
) so I am stripping that out so I can move forward with #1279
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most likely I still have some errors / corner cases in this logic that I will find when indexing a production dump.
# granted to it by virtue of its status as an Intergovernmental Organization | ||
# or submit itself to any jurisdiction. | ||
|
||
"""Helpers for handling pubnote parsing.""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the 'basic' questions, but what is a pubnote?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A pubnote is the ,
-concatenation of: short journal title
, volume
, page(s)
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
942f1cf
to
8875a8b
Compare
Signed-off-by: Mihai Bivol <mihai.bivol@cern.ch>
* Moves references view logic into own module Signed-off-by: Mihai Bivol <mihai.bivol@cern.ch>
* Adds class for building references given simple fields and correctly clean unique identifers for references Note: This is not used yet since the PR would be too big Signed-off-by: Mihai Bivol <mihai.bivol@cern.ch>
inspirehep.references
moduleinspirehep.utils