This repository was archived by the owner on Jan 14, 2026. It is now read-only.
Release the chunkBuffer if an exception is thrown whilst reading#26
Merged
Merged
Conversation
If an exception was thrown due to an issue whilst reading the MetricFamily into the slice, the buffer wasn't released and Netty complained about ByteBuf being gc'ed without being explicitly released.
Author
|
@zegelin Would you mind having a review please when you have a chance (I can't seem to ask you on GitHub to be a reviewer) |
|
@suhailpatel will review shortly. Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If an exception was thrown due to an issue whilst reading the MetricFamily into the slice, the buffer wasn't released. Netty complains about ByteBuf being gc'ed without being explicitly released.