Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add cron prune image and refactor api #44

Merged
merged 1 commit into from Mar 3, 2019

Conversation

Projects
None yet
2 participants
@wei
Copy link
Member

wei commented Mar 3, 2019

  • add cron prune image
  • refactored project and created instantboxManager
  • remove redis dependency
  • make rmOS endpoint stateless

Close #42 when merged

@wei wei added the enhancement label Mar 3, 2019

@wei wei self-assigned this Mar 3, 2019

@wei wei requested a review from import-yuefeng Mar 3, 2019

@wei wei force-pushed the refactor-add-prune branch from 8017a36 to 21665a1 Mar 3, 2019

if open_port is None:
port_dict = {'1588/tcp': None}
else:
port_dict = {'1588/tcp': None, '{}/tcp'.format(open_port): None}

This comment has been minimized.

@wei

wei Mar 3, 2019

Author Member

https://docker-py.readthedocs.io/en/stable/containers.html

None, to assign a random host port. For example, {'2222/tcp': None}.

@wei wei force-pushed the refactor-add-prune branch from 21665a1 to abe05ff Mar 3, 2019

@import-yuefeng
Copy link
Member

import-yuefeng left a comment

LGTM

@wei wei merged commit adb12f0 into master Mar 3, 2019

@wei wei deleted the refactor-add-prune branch Mar 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.