Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve web console routing #63

Merged
merged 1 commit into from Jun 26, 2019

Conversation

Projects
None yet
2 participants
@wei
Copy link
Member

commented Jun 21, 2019

Previously we were creating and binding a host port for each instantbox created. This PR updates it so that is no longer necessary. Instead, users will be taken to /console/{instantbox_id} for the web console.

Pros:

  • More secure, harder to brute force and guess.
  • It can be secured (SSL) along with the main site without additional effort.

Cons:

  • It creates a docker network for each host, which has limit of ~30 per host? Personally, I think that's plenty for now, if necessary, this # can be further extended by putting all containers on the same network after securing all instantbox docker images by adding firewall.
  • I changed the random naming to use lowercase letters and numbers to get around a docker dns casing limitation. moby/moby#21169

For future reference: change network mode to overlay in swarm mode, this will solve the network limitations mentioned in Cons (1).

The accompanied front-end PR is here: instantbox/instantbox-frontend#14

@wei wei added the enhancement label Jun 21, 2019

@wei wei requested a review from import-yuefeng Jun 21, 2019

@wei wei force-pushed the webconsole-routing branch from 3f026c8 to b6c7ccc Jun 21, 2019

@wei wei changed the title Improve Web Console Routing feat: improve web console routing Jun 21, 2019

@import-yuefeng
Copy link
Member

left a comment

LGTM

@import-yuefeng import-yuefeng merged commit 35f5d60 into master Jun 26, 2019

2 checks passed

Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details

@wei wei deleted the webconsole-routing branch Jun 26, 2019

@wei wei self-assigned this Jun 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.