Skip to content

Conversation

@heiruwu
Copy link
Contributor

@heiruwu heiruwu commented Jan 5, 2024

Because

  • provide better DX when configuring connectors, operators and components

This commit

  • add Makefile target and bash script to fetch resources and tasks definitions jsonschema
  • add Makefile target and bash script to generate dataclass classes for resources config type hint from jsonschema
  • add airbyte connectors
  • adopt dataclass config and jsonschema validations in connectors and operators
  • add necessary packages in poetry project file

resolves ins-3294
resolves ins-3295
resolves ins-3296
resolves ins-3297
resolves ins-3298

@linear
Copy link

linear bot commented Jan 5, 2024

@codecov
Copy link

codecov bot commented Jan 5, 2024

Codecov Report

Attention: 1800 lines in your changes are missing coverage. Please review.

Comparison is base (903bc29) 34.43% compared to head (1da46dd) 15.32%.

Files Patch % Lines
instill/resources/connector_airbyte.py 0.00% 454 Missing ⚠️
instill/resources/connector_ai.py 39.28% 34 Missing ⚠️
...esources/schema/openai_task_text_to_image_input.py 0.00% 33 Missing ⚠️
...sources/schema/openai_task_text_to_speech_input.py 0.00% 33 Missing ⚠️
...es/schema/huggingface_task_conversational_input.py 0.00% 29 Missing ⚠️
...s/schema/huggingface_task_text_generation_input.py 0.00% 26 Missing ⚠️
...ces/schema/huggingface_task_summarization_input.py 0.00% 24 Missing ⚠️
...schema/huggingface_task_object_detection_output.py 0.00% 23 Missing ⚠️
...chema/instill_task_semantic_segmentation_output.py 0.00% 23 Missing ⚠️
...ces/schema/huggingface_task_text_to_image_input.py 0.00% 22 Missing ⚠️
... and 92 more
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #74       +/-   ##
===========================================
- Coverage   34.43%   15.32%   -19.12%     
===========================================
  Files          25      163      +138     
  Lines        1658     6325     +4667     
  Branches      419     1063      +644     
===========================================
+ Hits          571      969      +398     
- Misses       1070     5339     +4269     
  Partials       17       17               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@heiruwu heiruwu changed the title feat(connector): adopt jsonscema validation and dataclass type hint feat(connector,operator,component): adopt jsonscema validation and dataclass type hint Jan 5, 2024
@heiruwu heiruwu merged commit 0c47e51 into main Jan 5, 2024
@heiruwu heiruwu deleted the INS-3276 branch January 5, 2024 13:23
heiruwu pushed a commit that referenced this pull request Jan 15, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.6.0](v0.5.0...v0.6.0)
(2024-01-12)


### Features

* **connector,operator,component:** adopt jsonscema validation and
dataclass type hint
([#74](#74))
([0c47e51](0c47e51))
* **helpers:** add wrapper func for protobuf message
([#85](#85))
([279bd1e](279bd1e))
* **resource:** adopt dataclass as config in component for type hinting
([#79](#79))
([8c25bd1](8c25bd1))
* **resources:** support recipe update in pipeline resource
([#83](#83))
([89431fa](89431fa))


### Bug Fixes

* **resources:** fix resource schema path
([#76](#76))
([25f4418](25f4418))


### Documentation

* **notebook:** update notebook
([e5da642](e5da642))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: 👋 Done

Development

Successfully merging this pull request may close these issues.

3 participants