fix(client)!: fix wrongful delete of resources and connection not close #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
INS-2506 [Bug] python program stuck if resources not cleansed
Is There an Existing Issue for This?
ProjectInstill SDK Describe the Bugif a script does not deliberately delete the resource, the program will not exit. Steps to Reproduce
Actual Resultprogram stuck Expected Behaviorprogram exit after all codes ran Technical Details
Anything Else?No response |
heiruwu
deleted the
heiru/ins-2506-bug-python-program-stuck-if-resources-not-cleansed
branch
heiruwu
added a commit
that referenced
this pull request
Nov 2, 2023
…se (#42) Because - grpc channel not close - overwriting `_del_` is a will cause resource deletion after script finish This commit - move resource function `_del_` to `delete` - close grpc channels propely
heiruwu
added a commit
that referenced
this pull request
Nov 2, 2023
…se (#42) Because - grpc channel not close - overwriting `_del_` will cause resource deletion after script finish This commit - move resource function `_del_` to `delete` - close grpc channels propely
heiruwu
pushed a commit
that referenced
this pull request
Nov 7, 2023
🤖 I have created a release *beep* *boop* --- ## [0.3.0](v0.2.1...v0.3.0) (2023-11-07) ### ⚠ BREAKING CHANGES * **client:** fix wrongful delete of resources and connection not close ([#42](#42)) ### Features * **ray:** add help functions for ray model ([#40](#40)) ([39b2cc7](39b2cc7)) ### Bug Fixes * **client:** fix wrongful delete of resources and connection not close ([#42](#42)) ([d32fb83](d32fb83)) * **config,pipeline:** allow no config file and fix required pipeline recipe ([#43](#43)) ([5290868](5290868)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
_del_is a will cause resource deletion after script finishThis commit
_del_todelete