fix(config,pipeline): allow no config file and fix required pipeline recipe #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
INS-2507 [Improvement] optional config file for python-sdk
Is There an Existing Issue for This?
ProjectInstill SDK Is your Proposal Related to a Problem?config file is cumbersome for sdk usage Describe Your Proposed Improvementmake config file optional, and allow setting the Highlight the Benefitsbetter user experience Anything Else?No response INS-2505 [Bug] `recipe` should be optional when creating a `Pipeline` object with existing pipeline
Is There an Existing Issue for This?
ProjectInstill SDK Describe the Bugwhen using python-sdk, creating a Steps to Reproduce
wont work Actual ResultExpected Behaviorno error Technical Details
Anything Else?No response |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #43 +/- ##
==========================================
+ Coverage 53.40% 53.52% +0.12%
==========================================
Files 23 23
Lines 882 880 -2
Branches 177 176 -1
==========================================
Hits 471 471
+ Misses 392 390 -2
Partials 19 19
☔ View full report in Codecov by Sentry. |
heiruwu
deleted the
heiru/ins-2507-improvement-optional-config-file-for-python-sdk
branch
heiruwu
pushed a commit
that referenced
this pull request
Nov 7, 2023
🤖 I have created a release *beep* *boop* --- ## [0.3.0](v0.2.1...v0.3.0) (2023-11-07) ### ⚠ BREAKING CHANGES * **client:** fix wrongful delete of resources and connection not close ([#42](#42)) ### Features * **ray:** add help functions for ray model ([#40](#40)) ([39b2cc7](39b2cc7)) ### Bug Fixes * **client:** fix wrongful delete of resources and connection not close ([#42](#42)) ([d32fb83](d32fb83)) * **config,pipeline:** allow no config file and fix required pipeline recipe ([#43](#43)) ([5290868](5290868)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This commit
recipeargument even with existing resourceResolves INS-2505