Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move SubmissionCommentsTests to SwiftUITests #156

Merged
merged 1 commit into from May 10, 2019

Conversation

Projects
None yet
3 participants
@bootstraponline
Copy link
Member

commented May 3, 2019

All tests passing!

@instructure instructure deleted a comment from inst-danger May 3, 2019

@bootstraponline bootstraponline force-pushed the SwiftUITest branch 2 times, most recently from e5cb525 to 70fe603 May 3, 2019

@inst-danger

This comment has been minimized.

Copy link
Contributor

commented May 3, 2019

Coverage New % Master % Delta
Core 93.52% 93.52% 0%
Student 92.33% 92.33% 0%
Teacher 100% 100% 0%
React Native 92.72% 92.72% 0%

Generated by 🚫 dangerJS

@bootstraponline bootstraponline force-pushed the SwiftUITest branch 2 times, most recently from c10f8a6 to ac56cfd May 4, 2019

static var loadingView = app.find(AudioRecorder.loadingView)
static var playPauseButton = app.find(AudioRecorder.playPauseButton)
static var remainingTimeLabel = app.find(AudioRecorder.remainingTimeLabel)
static var timeSlider = app.find(AudioRecorder.timeSlider)

This comment has been minimized.

Copy link
@vanwagonet

vanwagonet May 6, 2019

Contributor

if these are lazy initialized in a test, would other tests that use them end up referencing the wrong XCTestCase?

This comment has been minimized.

Copy link
@bootstraponline

bootstraponline May 6, 2019

Author Member

Thanks. I pushed a fix to always recompute the app variable.

@bootstraponline bootstraponline force-pushed the SwiftUITest branch 2 times, most recently from 4d99f56 to fb4cb1c May 8, 2019

@bootstraponline

This comment has been minimized.

Copy link
Member Author

commented May 9, 2019

PDF tests seem broken, also getting a weird mocking error.

7 tests are broken using the EarlGrey driver, I'm looking into that.

@bootstraponline bootstraponline force-pushed the SwiftUITest branch 3 times, most recently from ec2d4cd to a48b997 May 9, 2019

static func attemptCell(submissionID: String, attempt: Int) -> SubmissionComments {
return SubmissionComments(rawValue: "attemptCell.submission-\(submissionID)-\(attempt)")
static func attemptCell(submissionID: String, attempt: Int) -> Element {
return app.find(id: "\(className).attemptCell.submission-\(submissionID)-\(attempt)")

This comment has been minimized.

Copy link
@vanwagonet

vanwagonet May 9, 2019

Contributor

I think this is a good way to go forward.

@bootstraponline bootstraponline force-pushed the SwiftUITest branch from a48b997 to a60a2bf May 10, 2019

Move SubmissionCommentsTests to SwiftUITests
[ignore-commit-lint]

Fix SubmissionFilesTests testFilesList

Update EarlGrey & SwiftUITest

Use new find by ElementId

Always recompute app

Add EarlGrey driver

FIx SubmissionComments test

Use new pattern on AudioRecorder / testAudioRecording

Convert to ElementWrapper

@bootstraponline bootstraponline force-pushed the SwiftUITest branch from a60a2bf to 21ba47a May 10, 2019

@bootstraponline bootstraponline changed the title WIP | Move SubmissionCommentsTests to SwiftUITests Move SubmissionCommentsTests to SwiftUITests May 10, 2019

@bootstraponline bootstraponline merged commit 0e9d3b0 into master May 10, 2019

10 of 14 checks passed

ci/bitrise/2acbfdecb49e1c81/pr Failed - iOS Open Source Teacher
Details
ci/bitrise/45e544bf0c9d1c14/pr Failed - iOS Open Source Parent
Details
ci/bitrise/72a41ea6e1d3f173/pr Failed - Canvas iOS Danger
Details
ci/bitrise/ef85ce73f808ae43/pr Failed - iOS Open Source Student
Details
ci/bitrise/13a8648ad7201c0d/push Passed - Canvas iOS Teacher
Details
ci/bitrise/57b22415f35222e3/pr Passed - Canvas iOS Student UI Tests
Details
ci/bitrise/88a3641e29e4745c/push Passed - Canvas iOS Student
Details
ci/bitrise/b852157b84aa86aa/push Passed - Canvas iOS Lint New Student
Details
ci/bitrise/bd385a53a16abb46/push Passed - Canvas iOS Parent
Details
license/cla Contributor License Agreement is signed.
Details
license/snyk - package.json (Instructure) No manifest changes detected
license/snyk - rn/Teacher/package.json (Instructure) No manifest changes detected
security/snyk - package.json (Instructure) No manifest changes detected
security/snyk - rn/Teacher/package.json (Instructure) No manifest changes detected

@bootstraponline bootstraponline deleted the SwiftUITest branch May 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.