Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove strip PSPDFKit #27

Merged
merged 1 commit into from Mar 4, 2019

Conversation

Projects
None yet
3 participants
@bootstraponline
Copy link
Member

bootstraponline commented Mar 4, 2019

"Do not use strip-framework.sh or other scripts, as they are not necessary when using Carthage and will prevent your project from working."
https://pspdfkit.com/guides/ios/current/getting-started/using-carthage/#important%20t

Remove strip PSPDFKit
"Do not use strip-framework.sh or other scripts, as they are not necessary when using Carthage and will prevent your project from working."
https://pspdfkit.com/guides/ios/current/getting-started/using-carthage/#important%20t
@inst-danger

This comment has been minimized.

Copy link
Contributor

inst-danger commented Mar 4, 2019

Fails
🚫

Please add a release note. If no release note is wanted, use none. Example: release note: Fixed a bug that prevented users from enjoying the app.

🚫

Please add which apps this change affects. Example: affects: Teacher, Student or affects: none

🚫

Please add a reference to a jira ticket. For example: refs: MBL-10023

Coverage New % Master % Delta
Core 90.2% 90.13% 0.07%
Student 95.05% 95.05% 0%
Teacher 100% 100% 0%
React Native 92.3% 92.3% 0%

Generated by 🚫 dangerJS

@bootstraponline bootstraponline merged commit 4a1a892 into master Mar 4, 2019

9 of 10 checks passed

Danger :warning: Danger found some issues. Don't worry, everything is fixable.
Details
ci/bitrise/13a8648ad7201c0d/push Passed - Canvas iOS Teacher
Details
ci/bitrise/72a41ea6e1d3f173/pr Passed - Canvas iOS Danger
Details
ci/bitrise/88a3641e29e4745c/push Passed - Canvas iOS Student
Details
ci/bitrise/bd385a53a16abb46/push Passed - Canvas iOS Parent
Details
license/cla Contributor License Agreement is signed.
Details
license/snyk - package.json (Instructure) No manifest changes detected
license/snyk - rn/Teacher/package.json (Instructure) No manifest changes detected
security/snyk - package.json (Instructure) No manifest changes detected
security/snyk - rn/Teacher/package.json (Instructure) No manifest changes detected

@bootstraponline bootstraponline deleted the pspdfkit branch Mar 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.