Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix warnings #36

Merged
merged 1 commit into from Mar 5, 2019

Conversation

Projects
None yet
3 participants
@bluwave
Copy link
Contributor

bluwave commented Mar 5, 2019

refs: MBL-12111
affects: none
release note: none

fix warnings
refs: MBL-12111
affects: none
release note: none
@inst-danger

This comment has been minimized.

Copy link
Contributor

inst-danger commented Mar 5, 2019

Warnings
⚠️

This pull request will not generate a release note.

Affected Apps: None

MBL-12111

Coverage New % Master % Delta
Core 90.48% 90.48% 0%
Student 94.52% 94.52% 0%
Teacher 100% 100% 0%
React Native 92.3% 92.3% 0%

Generated by 🚫 dangerJS

@bluwave bluwave merged commit 3f17824 into master Mar 5, 2019

10 of 11 checks passed

ci/bitrise/57b22415f35222e3/push Failed - Canvas iOS Student UI Tests
Details
Danger :warning: Danger found some issues. Don't worry, everything is fixable.
Details
ci/bitrise/13a8648ad7201c0d/push Passed - Canvas iOS Teacher
Details
ci/bitrise/72a41ea6e1d3f173/pr Passed - Canvas iOS Danger
Details
ci/bitrise/88a3641e29e4745c/push Passed - Canvas iOS Student
Details
ci/bitrise/bd385a53a16abb46/push Passed - Canvas iOS Parent
Details
license/cla Contributor License Agreement is signed.
Details
license/snyk - package.json (Instructure) No manifest changes detected
license/snyk - rn/Teacher/package.json (Instructure) No manifest changes detected
security/snyk - package.json (Instructure) No manifest changes detected
security/snyk - rn/Teacher/package.json (Instructure) No manifest changes detected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.