Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Core.framework to StudentShare target #37

wants to merge 2 commits into
base: master


None yet
3 participants
Copy link

shichongrui commented Mar 5, 2019

No description provided.

@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
LastUpgradeVersion = "1010"
LastUpgradeVersion = "1000"

This comment has been minimized.


bootstraponline Mar 5, 2019


Is that intentional? I think this was just updated to 1010 in #36


This comment has been minimized.

Copy link

inst-danger commented Mar 5, 2019


Please add a release note. If no release note is wanted, use none. Example: release note: Fixed a bug that prevented users from enjoying the app.


Please add which apps this change affects. Example: affects: Teacher, Student or affects: none


Please add a reference to a jira ticket. For example: refs: MBL-10023

Coverage New % Master % Delta
Core 90.43% 90.46% -0.03%
Student 94.52% 94.52% 0%
Teacher 100% 100% 0%
React Native 92.3% 92.3% 0%

Generated by 🚫 dangerJS


This comment has been minimized.

Copy link

bootstraponline commented Mar 5, 2019

I merged this in #39

@bootstraponline bootstraponline deleted the fix-student-archive branch Mar 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.