Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix signing #39

Merged
merged 3 commits into from Mar 5, 2019

Conversation

Projects
None yet
5 participants
@bootstraponline
Copy link
Member

bootstraponline commented Mar 5, 2019

No description provided.

shichongrui and others added some commits Mar 5, 2019

@@ -1489,7 +1491,7 @@
};
F9E7D0CE215BE19F00CDC1A3 = {
CreatedOnToolsVersion = 10.0;
ProvisioningStyle = Manual;
ProvisioningStyle = Automatic;

This comment has been minimized.

@vanwagonet

vanwagonet Mar 5, 2019

Contributor

\o/

This comment has been minimized.

@bluwave

bluwave Mar 5, 2019

Contributor

\o/

@bootstraponline bootstraponline merged commit acec384 into master Mar 5, 2019

9 of 11 checks passed

ci/bitrise/57b22415f35222e3/push Aborted - Canvas iOS Student UI Tests
Details
ci/bitrise/72a41ea6e1d3f173/pr In progress - Canvas iOS Danger
Details
ci/bitrise/13a8648ad7201c0d/push Passed - Canvas iOS Teacher
Details
ci/bitrise/88a3641e29e4745c/push Passed - Canvas iOS Student
Details
ci/bitrise/b852157b84aa86aa/push Passed - Canvas iOS Lint New Student
Details
ci/bitrise/bd385a53a16abb46/push Passed - Canvas iOS Parent
Details
license/cla Contributor License Agreement is signed.
Details
license/snyk - package.json (Instructure) No manifest changes detected
license/snyk - rn/Teacher/package.json (Instructure) No manifest changes detected
security/snyk - package.json (Instructure) No manifest changes detected
security/snyk - rn/Teacher/package.json (Instructure) No manifest changes detected

@bootstraponline bootstraponline deleted the fix_signing branch Mar 5, 2019

@inst-danger

This comment has been minimized.

Copy link
Contributor

inst-danger commented Mar 5, 2019

Fails
🚫

Please add a release note. If no release note is wanted, use none. Example: release note: Fixed a bug that prevented users from enjoying the app.

🚫

Please add which apps this change affects. Example: affects: Teacher, Student or affects: none

🚫

Please add a reference to a jira ticket. For example: refs: MBL-10023

Coverage New % Master % Delta
Core 90.48% 90.46% 0.02%
Student 94.52% 94.52% 0%
Teacher 100% 100% 0%
React Native 92.3% 92.3% 0%

Generated by 🚫 dangerJS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.