Please sign in to comment.
separate user and context ids in permission caching keys
cached_context_grants_right?'s key generation scheme could potentially cause the wrong permissions to be returned with the old scheme, both (course_123, user_45) and (course_12, user_345) would key cache entries with "course_12345". this could cause already cached permissions to be used when they shouldn't be in some ridiculously unlikely scenarios, made all the more unlikely because cached_context_grants_right? is an in-process cache Change-Id: I12d4f2a7e982d2a98825df31b35a784366df9c36 Reviewed-on: https://gerrit.instructure.com/19185 Tested-by: Jenkins <email@example.com> Reviewed-by: Brian Palmer <firstname.lastname@example.org> Product-Review: Joel Hough <email@example.com> QA-Review: Joel Hough <firstname.lastname@example.org>
- Loading branch information...
Showing with 1 addition and 1 deletion.