From cd03c7f8b6d7eb6b69ab9d648e523baf8df19991 Mon Sep 17 00:00:00 2001 From: Ryan Shaw Date: Mon, 22 Aug 2016 14:03:32 -0600 Subject: [PATCH] Add helpful gergich suggestion about ERB warning Change-Id: Id158bac164b3fdb989ed27faef085f4600ccabf6 Reviewed-on: https://gerrit.instructure.com/88425 Reviewed-by: Landon Wilkins Product-Review: Landon Wilkins QA-Review: Landon Wilkins Tested-by: Jenkins --- script/tatl_tael | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/script/tatl_tael b/script/tatl_tael index e8f4eb069d1d..1cd0ddc45398 100755 --- a/script/tatl_tael +++ b/script/tatl_tael @@ -51,7 +51,14 @@ errors = [] linter.ban_new_erb do errors << "Your commit includes new ERB files,"\ " which has been a no-no in Canvas since 2011."\ - " All new UI should be built in React on top of documented APIs" + " All new UI should be built in React on top of documented APIs.\n"\ + "Maybe try doing something like this in your controller instead:\n\n"\ + " @page_title = t('Your Page Title')\n"\ + " @body_classes << 'whatever-classes you-want-to-add-to-body'\n"\ + " js_bundle :your_js_bundle\n"\ + " css_bundle :any_css_bundles_you_want\n"\ + " js_env({whatever: 'you need to put in window.ENV'})\n"\ + " render :text => "".html_safe, :layout => true"\ end linter.ensure_public_js_specs do