Permalink
Commits on Feb 10, 2016
  1. @codekitchen

    limit the data sent to sentry/error_reports

    The request body params can be unbounded in size, so if they're too
    large, truncate the string.
    
    Change-Id: Icc3a7bc27227f38a05cc5fc67789616cd3c71fd3
    Reviewed-on: https://gerrit.instructure.com/71867
    Reviewed-by: Cody Cutrer <cody@instructure.com>
    Tested-by: Jenkins
    Product-Review: Brian Palmer <brianp@instructure.com>
    QA-Review: Brian Palmer <brianp@instructure.com>
    codekitchen committed Feb 9, 2016
  2. @codekitchen @ccutrer

    restore cache store logging in rails 4.0

    fixes CNVS-26757
    
    It turns out this code is still necessary in rails 4.0, it's the rails
    4.2 branch where it is deprecated and always true.
    
    test plan: do some redis cache reads and writes, verify the "CacheStore"
    lines appear in the debug logs.
    
    Change-Id: I51a2696f3e7104c8d54f0b5bb5ca61fac0e20656
    Reviewed-on: https://gerrit.instructure.com/71155
    Reviewed-by: Simon Williams <simon@instructure.com>
    QA-Review: August Thornton <august@instructure.com>
    Tested-by: Jenkins
    Product-Review: Brian Palmer <brianp@instructure.com>
    codekitchen committed with ccutrer Jan 29, 2016
Commits on Feb 9, 2016
  1. @codekitchen @mcwqy9

    switch api doc syntax highlighter theme

    The sunburst theme wasn't high contrast enough.
    
    test plan: `rake doc:api` and the generated api docs should be using the
    default prettify.js theme, which is darker text on a white background.
    
    Change-Id: I44f3e105ea11a99308163318db675f9be5c41f24
    Reviewed-on: https://gerrit.instructure.com/71813
    Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
    Tested-by: Jenkins
    Product-Review: Brian Palmer <brianp@instructure.com>
    QA-Review: Brian Palmer <brianp@instructure.com>
    codekitchen committed with mcwqy9 Feb 9, 2016
  2. @codekitchen

    use our pre-built kinesalite docker image

    This image is an appliance more in line with the postgres or redis
    images, so it manages its own data volume. Thus the docker-compose and
    doc file changes.
    
    Change-Id: I8f435400bd8427313d0bc290c84cd44639ead074
    Reviewed-on: https://gerrit.instructure.com/71502
    Tested-by: Jenkins
    Reviewed-by: Simon Williams <simon@instructure.com>
    Product-Review: Brian Palmer <brianp@instructure.com>
    QA-Review: Brian Palmer <brianp@instructure.com>
    codekitchen committed Feb 4, 2016
  3. @codekitchen

    switch api doc syntax highlighter theme

    The sunburst theme wasn't high contrast enough.
    
    test plan: `rake doc:api` and the generated api docs should be using the
    default prettify.js theme, which is darker text on a white background.
    
    Change-Id: I44f3e105ea11a99308163318db675f9be5c41f24
    Reviewed-on: https://gerrit.instructure.com/71813
    Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
    Tested-by: Jenkins
    Product-Review: Brian Palmer <brianp@instructure.com>
    QA-Review: Brian Palmer <brianp@instructure.com>
    codekitchen committed Feb 9, 2016
Commits on Feb 5, 2016
  1. @codekitchen

    restore the bootstrap param to consul

    I removed this in my change because consul outputted a warning
    suggesting that I didn't really want it... but I think what it was
    actually saying was use `-bootstrap` instead of `-bootstrap-expect 1`.
    
    This fixes an intermittent error if the canvas dev container tries to
    query consul before it is ready.
    
    Change-Id: I48988592f9cbea4c32b372461f56ebbd8b34567c
    Reviewed-on: https://gerrit.instructure.com/71583
    QA-Review: Steven Burnett <sburnett@instructure.com>
    Reviewed-by: Ethan Vizitei <evizitei@instructure.com>
    Product-Review: Brian Palmer <brianp@instructure.com>
    Tested-by: Brian Palmer <brianp@instructure.com>
    codekitchen committed Feb 5, 2016
Commits on Feb 4, 2016
  1. @codekitchen

    replace our custom consul dev container

    This removes our custom-built consul docker container (only used in
    development) and replaces it with a popular public image from the docker
    registry.
    
    Change-Id: I7d42117e704f60b99f8e7f2895e9fb1b029c15f2
    Reviewed-on: https://gerrit.instructure.com/71511
    Reviewed-by: Ethan Vizitei <evizitei@instructure.com>
    Tested-by: Jenkins
    Product-Review: Brian Palmer <brianp@instructure.com>
    QA-Review: Brian Palmer <brianp@instructure.com>
    codekitchen committed Feb 4, 2016
  2. @codekitchen

    add float#inf to the list of safe yaml tags

    refs sentry error 131648
    
    It's probably not valid to have a submission with a score of
    Infinity anyway, but either way we need to whitelist the tag so we can
    at least load the versioned yaml blob without erroring.
    
    test plan:
     * Have a blob of YAML in the db with an Infinite value for a float
       field, for instance a submission with a score of Infinity. I'm not
       sure how to set this up, but it apparently happens.
     * loading speedgrader for that assignment should work
    
    Change-Id: I768dae29ae3d8bd2f3ab0a0b7d55883bbf89834b
    Reviewed-on: https://gerrit.instructure.com/71216
    Reviewed-by: Cody Cutrer <cody@instructure.com>
    Tested-by: Jenkins
    QA-Review: August Thornton <august@instructure.com>
    Product-Review: Brian Palmer <brianp@instructure.com>
    codekitchen committed Feb 1, 2016
Commits on Feb 2, 2016
  1. @codekitchen @ccutrer

    avoid doing empty kaltura bulk uploads

    refs sentry error 33018
    
    It's very common for us to filter out the lone attachment passed in to
    KalturaMediaFileHandler#add_media_files because the attachment already
    has a media_object. In that situation, we've been posting a blank csv
    upload to kaltura anyway, causing errors further down the processes.
    
    test plan: this can happen on uploading a media file, but doesn't always
    happen, so it might be difficult to intentionally trigger from the ui. From the
    rails console you could attempt to re-upload an attachment that already
    has a media_object, using something like
    `KalturaMediaFileHandler.new.add_media_files([my_attachment], false)`
    and verify that no exception is raised.
    
    Change-Id: Ia89550df2883f240a2fbc287e0cd2a4086b5b6fb
    Reviewed-on: https://gerrit.instructure.com/71214
    Reviewed-by: Rob Orton <rob@instructure.com>
    Tested-by: Jenkins
    QA-Review: August Thornton <august@instructure.com>
    Product-Review: Brian Palmer <brianp@instructure.com>
    codekitchen committed with ccutrer Feb 1, 2016
  2. @codekitchen @ccutrer

    don't raise/record an error when a file link can't be found

    refs sentry error 33094
    
    This isn't an actionable error, it typically just means bad content was
    imported. It's also extremely common due to content imports. Note that
    the import warning "Missing links found in imported content" is still
    recorded and displayed in the imports UI, this change just gets rid of
    the error report.
    
    test plan: import a common cartridge package that includes an assessment
    question that has html pointing to a non-existent image file. no error
    report should be generated, though you'll still see a warning in the ui
    about a missing link.
    
    Change-Id: Ic44ee446ed648388c87e022b80c695816f890e23
    Reviewed-on: https://gerrit.instructure.com/71162
    Tested-by: Jenkins
    Reviewed-by: James Williams  <jamesw@instructure.com>
    QA-Review: August Thornton <august@instructure.com>
    Product-Review: Brian Palmer <brianp@instructure.com>
    codekitchen committed with ccutrer Jan 29, 2016
  3. @codekitchen @ccutrer

    restore cache store logging in rails 4.0

    fixes CNVS-26757
    
    It turns out this code is still necessary in rails 4.0, it's the rails
    4.2 branch where it is deprecated and always true.
    
    test plan: do some redis cache reads and writes, verify the "CacheStore"
    lines appear in the debug logs.
    
    Change-Id: I51a2696f3e7104c8d54f0b5bb5ca61fac0e20656
    Reviewed-on: https://gerrit.instructure.com/71155
    Reviewed-by: Simon Williams <simon@instructure.com>
    QA-Review: August Thornton <august@instructure.com>
    Tested-by: Jenkins
    Product-Review: Brian Palmer <brianp@instructure.com>
    codekitchen committed with ccutrer Jan 29, 2016
Commits on Feb 1, 2016
  1. @codekitchen

    avoid doing empty kaltura bulk uploads

    refs sentry error 33018
    
    It's very common for us to filter out the lone attachment passed in to
    KalturaMediaFileHandler#add_media_files because the attachment already
    has a media_object. In that situation, we've been posting a blank csv
    upload to kaltura anyway, causing errors further down the processes.
    
    test plan: this can happen on uploading a media file, but doesn't always
    happen, so it might be difficult to intentionally trigger from the ui. From the
    rails console you could attempt to re-upload an attachment that already
    has a media_object, using something like
    `KalturaMediaFileHandler.new.add_media_files([my_attachment], false)`
    and verify that no exception is raised.
    
    Change-Id: Ia89550df2883f240a2fbc287e0cd2a4086b5b6fb
    Reviewed-on: https://gerrit.instructure.com/71214
    Reviewed-by: Rob Orton <rob@instructure.com>
    Tested-by: Jenkins
    QA-Review: August Thornton <august@instructure.com>
    Product-Review: Brian Palmer <brianp@instructure.com>
    codekitchen committed Feb 1, 2016
  2. @codekitchen

    don't raise/record an error when a file link can't be found

    refs sentry error 33094
    
    This isn't an actionable error, it typically just means bad content was
    imported. It's also extremely common due to content imports. Note that
    the import warning "Missing links found in imported content" is still
    recorded and displayed in the imports UI, this change just gets rid of
    the error report.
    
    test plan: import a common cartridge package that includes an assessment
    question that has html pointing to a non-existent image file. no error
    report should be generated, though you'll still see a warning in the ui
    about a missing link.
    
    Change-Id: Ic44ee446ed648388c87e022b80c695816f890e23
    Reviewed-on: https://gerrit.instructure.com/71162
    Tested-by: Jenkins
    Reviewed-by: James Williams  <jamesw@instructure.com>
    QA-Review: August Thornton <august@instructure.com>
    Product-Review: Brian Palmer <brianp@instructure.com>
    codekitchen committed Jan 29, 2016
  3. @codekitchen

    restore cache store logging in rails 4.0

    fixes CNVS-26757
    
    It turns out this code is still necessary in rails 4.0, it's the rails
    4.2 branch where it is deprecated and always true.
    
    test plan: do some redis cache reads and writes, verify the "CacheStore"
    lines appear in the debug logs.
    
    Change-Id: I51a2696f3e7104c8d54f0b5bb5ca61fac0e20656
    Reviewed-on: https://gerrit.instructure.com/71155
    Reviewed-by: Simon Williams <simon@instructure.com>
    QA-Review: August Thornton <august@instructure.com>
    Tested-by: Jenkins
    Product-Review: Brian Palmer <brianp@instructure.com>
    codekitchen committed Jan 29, 2016
  4. @codekitchen

    have sentry use our configured rails logger

    Change-Id: I31863e1a2f040b27a35c8b3d9c1ccb1539b67945
    Reviewed-on: https://gerrit.instructure.com/71156
    Tested-by: Jenkins
    Reviewed-by: Simon Williams <simon@instructure.com>
    Product-Review: Brian Palmer <brianp@instructure.com>
    QA-Review: Brian Palmer <brianp@instructure.com>
    codekitchen committed Jan 29, 2016
Commits on Jan 29, 2016
  1. @codekitchen

    fix media_object_failure errors

    Our video platform stopped transcoding to .flv a long time ago, so every
    single new upload was failing this check for .flv and generating an
    error report. What we really want is to ensure that the mp3/mp4
    transcoding is available, depending on if it is audio or video.
    
    This error didn't prevent the media from actually embedding and playing,
    which is why it was never really noticed before. So this commit is
    effectively just silencing noise.
    
    test plan: enable media uploads and upload a video/audio file. it should
    transcode and play as expected, and no media_object_failure error should
    be recorded.
    
    Change-Id: I960980ecff8a8235b0598b60fd257b22e9cd5f1f
    Reviewed-on: https://gerrit.instructure.com/71142
    Reviewed-by: Cody Cutrer <cody@instructure.com>
    Tested-by: Jenkins
    QA-Review: August Thornton <august@instructure.com>
    Product-Review: Brian Palmer <brianp@instructure.com>
    codekitchen committed Jan 29, 2016
Commits on Jan 26, 2016
  1. @codekitchen @roor0

    move user_id to dedicated errors report field

    closes CNVS-26758
    
    Sentry has a dedicated field for this now, opening up additional
    functionality such as a count of affected users for each error.
    
    test plan: enable sentry and trigger an in-request error, the error
    report will now include your user id in a separate "user" section.
    
    Change-Id: Ia58d54b923f7daa67e2ce060c02f0cfa0494387d
    Reviewed-on: https://gerrit.instructure.com/70918
    Reviewed-by: Simon Williams <simon@instructure.com>
    Tested-by: Jenkins
    Product-Review: Brian Palmer <brianp@instructure.com>
    QA-Review: Brian Palmer <brianp@instructure.com>
    codekitchen committed with roor0 Jan 23, 2016
  2. @codekitchen @roor0

    pass the canvas release to sentry

    closes CNVS-26745
    
    We were already passing it as a tag, but sentry now has a native release
    field that provides additional functionality, so pass it there as well.
    We'll keep the tag because it's still nice for searching.
    
    Change-Id: I5447ecabf3cc7246ebc36abd05829320d8d449a7
    Reviewed-on: https://gerrit.instructure.com/70889
    Reviewed-by: Simon Williams <simon@instructure.com>
    Tested-by: Jenkins
    Product-Review: Brian Palmer <brianp@instructure.com>
    QA-Review: Brian Palmer <brianp@instructure.com>
    codekitchen committed with roor0 Jan 22, 2016
Commits on Jan 23, 2016
  1. @codekitchen

    move user_id to dedicated errors report field

    closes CNVS-26758
    
    Sentry has a dedicated field for this now, opening up additional
    functionality such as a count of affected users for each error.
    
    test plan: enable sentry and trigger an in-request error, the error
    report will now include your user id in a separate "user" section.
    
    Change-Id: Ia58d54b923f7daa67e2ce060c02f0cfa0494387d
    Reviewed-on: https://gerrit.instructure.com/70918
    Reviewed-by: Simon Williams <simon@instructure.com>
    Tested-by: Jenkins
    Product-Review: Brian Palmer <brianp@instructure.com>
    QA-Review: Brian Palmer <brianp@instructure.com>
    codekitchen committed Jan 23, 2016
  2. @codekitchen

    pass the canvas release to sentry

    closes CNVS-26745
    
    We were already passing it as a tag, but sentry now has a native release
    field that provides additional functionality, so pass it there as well.
    We'll keep the tag because it's still nice for searching.
    
    Change-Id: I5447ecabf3cc7246ebc36abd05829320d8d449a7
    Reviewed-on: https://gerrit.instructure.com/70889
    Reviewed-by: Simon Williams <simon@instructure.com>
    Tested-by: Jenkins
    Product-Review: Brian Palmer <brianp@instructure.com>
    QA-Review: Brian Palmer <brianp@instructure.com>
    codekitchen committed Jan 22, 2016
Commits on Jan 21, 2016
  1. @codekitchen

    api docs scrollbars and sidebar color

    refs CNVS-26515
    
    A couple more tweaks from UX
    
    test plan: generate the api docs, bask in the glory. scrollbars should
    only appear when necessary on example code, not always.
    
    Change-Id: I2513ff160ddd226cb01614ec90e45780dec15a06
    Reviewed-on: https://gerrit.instructure.com/70787
    Reviewed-by: Colleen Palmer <colleen@instructure.com>
    Product-Review: Colleen Palmer <colleen@instructure.com>
    Tested-by: Jenkins
    QA-Review: Brian Palmer <brianp@instructure.com>
    codekitchen committed Jan 21, 2016
  2. @codekitchen

    spec: fix fragile spec due to undefined response ordering

    Change-Id: Ibd870d0b9bdf3c9d1e5893f094009bb8a901a01d
    Reviewed-on: https://gerrit.instructure.com/70792
    Reviewed-by: Jon Jensen <jon@instructure.com>
    Tested-by: Jenkins
    Product-Review: Brian Palmer <brianp@instructure.com>
    QA-Review: Brian Palmer <brianp@instructure.com>
    codekitchen committed Jan 21, 2016
Commits on Jan 20, 2016
  1. @codekitchen

    api doc styling updates

    refs CNVS-26515
    
    Some tweaks from UX to bring the docs more in line with the rest of
    Canvas, and better call out important information.
    
    test plan: generate and view the api docs
    
    Change-Id: Ibf1d56f1dcdd663d993efca8f48513136baa009b
    Reviewed-on: https://gerrit.instructure.com/70648
    Reviewed-by: Rob Orton <rob@instructure.com>
    Tested-by: Jenkins
    Product-Review: Brian Palmer <brianp@instructure.com>
    QA-Review: Brian Palmer <brianp@instructure.com>
    codekitchen committed Jan 20, 2016
  2. @codekitchen

    api doc request parameter formatting

    refs CNVS-26515
    
    Request params are now formatted in an HTML table, with separate fields
    for name, type, required/optional, valid enum values, and description.
    This is at the same time more compact and more readable.
    
    To parse this information out of what is actually free-form text
    comments, I'm re-using the OpenAPI (swagger) parsing code, which I
    tweaked and simplified slightly. Eventually I'd like to see the whole
    API documentation generated from the OpenAPI spec, and then we can
    slowly move away from using free-form code comments to more declarative
    code constructs, but still generate an OpenAPI spec and get the same API
    docs.
    
    test plan: Generate the api documentation, and view request parameter
    information. you should see the new formatting.
    
    Change-Id: Ida00869d96a9b2d9fa84c29079ddf2511a2d5917
    Reviewed-on: https://gerrit.instructure.com/70485
    Reviewed-by: Simon Williams <simon@instructure.com>
    Tested-by: Jenkins
    Product-Review: Brian Palmer <brianp@instructure.com>
    QA-Review: Brian Palmer <brianp@instructure.com>
    codekitchen committed Jan 18, 2016
  3. @codekitchen

    change float to number in api parameter definition

    This got merged in at the same time as my change that adds an error if
    you specify an invalid type.
    
    Change-Id: Iec37f2dc967d38752eb643dbdbbf5584e0ba08fb
    Reviewed-on: https://gerrit.instructure.com/70688
    Reviewed-by: Simon Williams <simon@instructure.com>
    Product-Review: Brian Palmer <brianp@instructure.com>
    QA-Review: Brian Palmer <brianp@instructure.com>
    Tested-by: Brian Palmer <brianp@instructure.com>
    codekitchen committed Jan 20, 2016
  4. @codekitchen

    fix typing of api doc @model definitions

    refs CNVS-26515
    
    Pretty much anything that wasn't a number was being rendered as a
    string, including sub-arrays and sub-objects. Worse, a lot of our api
    docs were defining them using ruby syntax rather than json syntax.
    
    This change fixes types so that booleans, arrays, and objects all render
    correctly in the @model docs (the "A ModuleItem object looks like:"
    sections of the docs). It also adds some basic error checking to help
    avoid future mistakes.
    
    This doesn't fully support the "$ref" OpenAPI (swagger) syntax yet, but
    still renders examples for "$ref" fields when an example is provided.
    Eventually it'd be nice to auto-generate an example for "$ref" fields,
    since we can look at the linked documentation and just embed it.
    
    test plan: generate the api documentation and look through the @model
    definitions at the top of each Resources page. the new rendering should
    show more accurate type information.
    
    Change-Id: Id5af514cd235e66af2ce868bce95eb49d71062ab
    Reviewed-on: https://gerrit.instructure.com/70484
    Tested-by: Jenkins
    Reviewed-by: Simon Williams <simon@instructure.com>
    Product-Review: Brian Palmer <brianp@instructure.com>
    QA-Review: Brian Palmer <brianp@instructure.com>
    codekitchen committed Jan 18, 2016
  5. @codekitchen

    further api doc syntax highlighting improvements

    refs CNVS-26515
    
    Renders the @model definitions as json, and improves the json
    formatting. Also renders all json as the prettify "js" type internally,
    because we put a lot of code comments in our json which isn't strictly json
    anymore, and so doesn't render correctly as json.
    
    test plan: compile the api docs and look at some @model blocks ("A File
    object looks like", e.g. in the Files API) to verify the new formatting.
    
    Change-Id: Icac9ad04bb42af80da66bc5ad0b5adead70ec168
    Reviewed-on: https://gerrit.instructure.com/70483
    Tested-by: Jenkins
    Reviewed-by: Rob Orton <rob@instructure.com>
    Product-Review: Brian Palmer <brianp@instructure.com>
    QA-Review: Brian Palmer <brianp@instructure.com>
    codekitchen committed Jan 16, 2016
  6. @codekitchen

    fix api route display

    refs CNVS-26515
    
    The rails4 upgrade changed the formatting so that this sub didn't match
    anymore, and we ended up with "(.:format)" on the end of each url.
    
    test plan: generate the api docs, the path for each endpoint shouldn't
    include "(.:format)" at the end.
    
    Change-Id: I8073c30d780b23abacc97f417e608db598415b28
    Reviewed-on: https://gerrit.instructure.com/70537
    Tested-by: Jenkins
    QA-Review: August Thornton <august@instructure.com>
    Reviewed-by: August Thornton <august@instructure.com>
    Product-Review: Brian Palmer <brianp@instructure.com>
    codekitchen committed Jan 18, 2016
Commits on Jan 15, 2016
  1. @codekitchen

    improve api documentation syntax highlighting

    refs CNVS-26515
    
    Switch to the prettify library and highlight not just json but html,
    xml, and bash.
    
    test plan:
    `rake doc:api` and open up the generated docs. throughout the docs, code
    should be syntax highlighted, including stuff like curl commands and xml
    that weren't highlighted before. It should be easier to copy/paste this
    code now, without a weird hidden text box appearing.
    
    Change-Id: Icd33159836826e144cb14b96187cb8c645559885
    Reviewed-on: https://gerrit.instructure.com/70345
    Reviewed-by: Brad Humphrey <brad@instructure.com>
    Tested-by: Jenkins
    Product-Review: Brian Palmer <brianp@instructure.com>
    QA-Review: Brian Palmer <brianp@instructure.com>
    codekitchen committed Jan 14, 2016
Commits on Jan 14, 2016
  1. @codekitchen

    move request_throttle code to app/middleware

    It is a middleware so it was in the wrong place. This solves class
    reloading problems in dev.
    
    test plan:
    
    request throttling should still function (you can look for "request
    throttling increment" log lines) and should no longer cause "A copy of
    Canvas::RequestThrottle has been removed from the module tree but is
    still active" errors.
    
    Change-Id: Ied6aaa6de4ac64ddfb14c80c76463f253b988bd7
    Reviewed-on: https://gerrit.instructure.com/70265
    Reviewed-by: Cody Cutrer <cody@instructure.com>
    Tested-by: Jenkins
    QA-Review: Jeremy Putnam <jeremyp@instructure.com>
    Product-Review: Brian Palmer <brianp@instructure.com>
    codekitchen committed Jan 14, 2016
Commits on Sep 17, 2015
  1. @codekitchen

    disable caching our custom headers in Rack::Cache

    this was causing problems with our logging infrastructure, since hundreds of
    requests were getting the same request id. instead, we'll treat this as
    basically a static asset request.
    
    fixes CNVS-23023
    
    test plan:
    
    without this commit, a GET /browserconfig.xml will always return the same
    X-Request-Context-Id and other headers. with this commit, these headers will be
    omitted completely from the generated response.
    
    normally Rack::Cache isn't enabled in development mode, but you can turn it on by setting config.action_controller.perform_caching = true in config/environments/development.rb
    
    Change-Id: I5e1164074d8c6977672364680a76888f561fa588
    Reviewed-on: https://gerrit.instructure.com/63454
    Tested-by: Jenkins
    Reviewed-by: Cody Cutrer <cody@instructure.com>
    Reviewed-by: Ryan Shaw <ryan@instructure.com>
    QA-Review: August Thornton <august@instructure.com>
    Product-Review: Brian Palmer <brianp@instructure.com>
    codekitchen committed Sep 16, 2015
Commits on Aug 20, 2015
  1. @codekitchen

    bump ratom-nokogiri

    fixes regression when generating an exception for invalid feed xml:
      instructure/ratom@bc19502
    
    Change-Id: I45c038f43c349fb2a07907a6e88ef16e3770bf29
    Reviewed-on: https://gerrit.instructure.com/61422
    Reviewed-by: Cody Cutrer <cody@instructure.com>
    QA-Review: August Thornton <august@instructure.com>
    Tested-by: Jenkins
    Product-Review: Brian Palmer <brianp@instructure.com>
    codekitchen committed Aug 20, 2015
Commits on Aug 14, 2015
  1. @codekitchen @ccutrer

    bump nokogiri

    Change-Id: Ibefaf48d0de044e52ee6e92655fb103c4b5d5511
    Reviewed-on: https://gerrit.instructure.com/60830
    Reviewed-by: Cody Cutrer <cody@instructure.com>
    QA-Review: Cody Cutrer <cody@instructure.com>
    Product-Review: August Thornton <august@instructure.com>
    Tested-by: Brian Palmer <brianp@instructure.com>
    codekitchen committed with ccutrer Aug 13, 2015
  2. @codekitchen @ccutrer

    switch to ratom-nokogiri gem

    refs CNVS-22298
    
    Change-Id: I4752fa491dcdd8f8f0eea9fb3b9ed63f2d0bb1e9
    Reviewed-on: https://gerrit.instructure.com/59981
    Reviewed-by: Cody Cutrer <cody@instructure.com>
    Tested-by: Jenkins
    QA-Review: August Thornton <august@instructure.com>
    Product-Review: Brian Palmer <brianp@instructure.com>
    codekitchen committed with ccutrer Aug 4, 2015
  3. @codekitchen @ccutrer

    switch to fork of nokogiri

    This is required for ratom until this PR is merged sparklemotion/nokogiri#1327
    
    refs CNVS-22298
    
    Change-Id: If99e10659b5b17e8cc8e0df49fbf5ba1214b8612
    Reviewed-on: https://gerrit.instructure.com/59948
    Reviewed-by: Cody Cutrer <cody@instructure.com>
    Tested-by: Jenkins
    QA-Review: August Thornton <august@instructure.com>
    Product-Review: Brian Palmer <brianp@instructure.com>
    codekitchen committed with ccutrer Aug 4, 2015