GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
When an assignment attached to a quiz or discussion topic is deleted, the corresponding quiz/topic remains.
This can lead to bugs. For example, after deleting a discussion topic assignment, the Edit Assignment Settings button on the discussion page results in an exception because the assignment no longer exists.
This pull requests fixes the Assignment.destroy behavior and adds corresponding specs.
As a side note, is this the correct behavior? The existing code implies the corresponding quiz/topic should be deleted, however It seems reasonable that a professor might actually want to remove the assignment associated with a topic/quiz without removing the actual topic/quiz. Thoughts?
Delete attached quiz/topic when assignment destroyed
Add tests for assignment.destroy behavior and fix bug that caused
attached quizzes and discussion topics to remain after assignment was
to whichever engineer ends up digging into this: not sure why the .reload's are necessary, but it seems like there's a root problem somewhere else that needs to be figured out, I just worry that this is a band-aid...
I don't believe this is a problem anymore.
Merge pull request #152 from va7map/canvas246
Start a New Ad Hoc Space form (CANVAS-246)