Delete attached quiz/topic when assignment destroyed #152

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants

blt04 commented Mar 28, 2012

When an assignment attached to a quiz or discussion topic is deleted, the corresponding quiz/topic remains.

This can lead to bugs. For example, after deleting a discussion topic assignment, the Edit Assignment Settings button on the discussion page results in an exception because the assignment no longer exists.

This pull requests fixes the Assignment.destroy behavior and adds corresponding specs.

As a side note, is this the correct behavior? The existing code implies the corresponding quiz/topic should be deleted, however It seems reasonable that a professor might actually want to remove the assignment associated with a topic/quiz without removing the actual topic/quiz. Thoughts?

Delete attached quiz/topic when assignment destroyed
Add tests for assignment.destroy behavior and fix bug that caused
attached quizzes and discussion topics to remain after assignment was
deleted.

to whichever engineer ends up digging into this: not sure why the .reload's are necessary, but it seems like there's a root problem somewhere else that needs to be figured out, I just worry that this is a band-aid...

Owner

simonista commented Mar 20, 2014

I don't believe this is a problem anymore.

@simonista simonista closed this Mar 20, 2014

grahamb pushed a commit to lunchgroup/canvas-lms that referenced this pull request Jan 18, 2016

Merge pull request #152 from va7map/canvas246
Start a New Ad Hoc Space form (CANVAS-246)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment