Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unpin holoviews in requirements.txt? #36

Closed
jhamman opened this issue Aug 8, 2019 · 5 comments · Fixed by #45
Closed

unpin holoviews in requirements.txt? #36

jhamman opened this issue Aug 8, 2019 · 5 comments · Fixed by #45

Comments

@jhamman
Copy link
Contributor

jhamman commented Aug 8, 2019

Would it be possible to unpin holoviews? We're finding that using xrviz is making downstream package management at this time?

xrviz/requirements.txt

Line 2 in e39c38a

holoviews==1.12.1

cc @scottyhq
@martindurant
Copy link
Member

@hdsingh , is there any reason to keep this pin?

@hdsingh
Copy link
Member

hdsingh commented Aug 9, 2019

This specific version was added about 2 weeks ago to get correct lon/lat values on the hover. The latest version of holoviews doesn't show correct values. Everything else works fine with the latest version.

@hdsingh
Copy link
Member

hdsingh commented Aug 9, 2019

https://github.com/pyviz/holoviews/issues/3891

@jhamman jhamman mentioned this issue Oct 7, 2019
Merged
@jhamman
Copy link
Contributor Author

jhamman commented Oct 7, 2019

This needs to be reopened.

@rsignell-usgs rsignell-usgs reopened this Oct 8, 2019
@hdsingh
Copy link
Member

hdsingh commented Oct 23, 2019

This has been resolved in #48.

@hdsingh hdsingh closed this as completed Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

unpin holoviews
4 participants
@rsignell-usgs @jhamman @martindurant @hdsingh