Skip to content

Commit

Permalink
ARROW-10225: [Rust] [Parquet] Fix null comparison in roundtrip
Browse files Browse the repository at this point in the history
Closes apache#8388 from nevi-me/ARROW-10225

Authored-by: Neville Dipale <nevilledips@gmail.com>
Signed-off-by: Neville Dipale <nevilledips@gmail.com>
  • Loading branch information
nevi-me committed Oct 16, 2020
1 parent 3a22d3d commit ead5e14
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions rust/parquet/src/arrow/arrow_writer.rs
Expand Up @@ -724,7 +724,11 @@ mod tests {
assert_eq!(expected_data.offset(), actual_data.offset());
assert_eq!(expected_data.buffers(), actual_data.buffers());
assert_eq!(expected_data.child_data(), actual_data.child_data());
assert_eq!(expected_data.null_bitmap(), actual_data.null_bitmap());
// Null counts should be the same, not necessarily bitmaps
// A null bitmap is optional if an array has no nulls
if expected_data.null_count() != 0 {
assert_eq!(expected_data.null_bitmap(), actual_data.null_bitmap());
}
}
}

Expand Down Expand Up @@ -1001,7 +1005,7 @@ mod tests {
}

#[test]
#[ignore] // Binary support isn't correct yet - null_bitmap doesn't match
#[ignore] // Binary support isn't correct yet - buffers don't match
fn binary_single_column() {
let one_vec: Vec<u8> = (0..SMALL_SIZE as u8).collect();
let many_vecs: Vec<_> = std::iter::repeat(one_vec).take(SMALL_SIZE).collect();
Expand All @@ -1026,7 +1030,6 @@ mod tests {
}

#[test]
#[ignore] // String support isn't correct yet - null_bitmap doesn't match
fn string_single_column() {
let raw_values: Vec<_> = (0..SMALL_SIZE).map(|i| i.to_string()).collect();
let raw_strs = raw_values.iter().map(|s| s.as_str());
Expand All @@ -1035,7 +1038,6 @@ mod tests {
}

#[test]
#[ignore] // Large string support isn't correct yet - null_bitmap doesn't match
fn large_string_single_column() {
let raw_values: Vec<_> = (0..SMALL_SIZE).map(|i| i.to_string()).collect();
let raw_strs = raw_values.iter().map(|s| s.as_str());
Expand Down

0 comments on commit ead5e14

Please sign in to comment.