Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix miscellaneous Sonar issues #28

Merged
merged 2 commits into from
Apr 21, 2024
Merged

Fix miscellaneous Sonar issues #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
352799a
Remove unused imports in Delphi units
fourls Apr 21, 2024
e07a6d5
Fix miscellaneous Sonar issues
fourls Apr 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion client/source/DelphiLint.Data.pas
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,7 @@ constructor TLintIssue.CreateFromJson(Json: TJSONObject);

MetadataJson := Json.GetValue<TJSONValue>('metadata', nil);
if Assigned(MetadataJson) and (MetadataJson is TJSONObject) then begin
FMetadata := TIssueMetadata.CreateFromJson(MetadataJson as TJSONObject);;
FMetadata := TIssueMetadata.CreateFromJson(MetadataJson as TJSONObject);
end;
end;

Expand Down
1 change: 0 additions & 1 deletion client/source/DelphiLint.Handlers.pas
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ interface
, Vcl.Graphics
, DelphiLint.Events
, DelphiLint.Context
, DelphiLint.Data
, DelphiLint.LiveData
;

Expand Down
1 change: 0 additions & 1 deletion client/source/DelphiLint.LiveData.pas
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ interface

uses
DelphiLint.Data
, System.Generics.Collections
;

type
Expand Down
1 change: 0 additions & 1 deletion client/source/DelphiLint.Plugin.pas
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,6 @@ implementation
, DelphiLint.SetupForm
, DelphiLint.Version
, DelphiLint.Resources
, DelphiLint.LiveData
;

//______________________________________________________________________________________________________________________
Expand Down
2 changes: 1 addition & 1 deletion client/source/DelphiLint.Utils.pas
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ function GetDelphiVersion: string;

// General utils
function TimeSpanToAgoString(TimeSpan: TTimeSpan): string;

type
TArrayUtils = class(TObject)
public
Expand All @@ -55,7 +56,6 @@ TArrayUtils = class(TObject)
class function Max<X>(Arr: TArray<X>; DefaultValue: X): X; overload; static;
end;

type
TWrapper<T> = class(TObject)
private
FRaw: T;
Expand Down
3 changes: 1 addition & 2 deletions client/test/DelphiLintTest.LiveData.pas
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,6 @@ interface

uses
DUnitX.TestFramework
, DelphiLint.Data
, System.JSON
;

type
Expand Down Expand Up @@ -66,6 +64,7 @@ implementation
uses
System.SysUtils
, DelphiLint.LiveData
, DelphiLint.Data
;

//______________________________________________________________________________________________________________________
Expand Down
1 change: 1 addition & 0 deletions companion/delphilint-vscode/src/extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ export function activate(context: vscode.ExtensionContext) {
"delphilint-vscode.clearThisFile",
() => clearThisFile(lintIssueCollection)
);
context.subscriptions.push(clearThisFileCommand);

const chooseActiveProjectCommand = vscode.commands.registerCommand(
"delphilint-vscode.chooseActiveProject",
Expand Down