Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a deployments API in slack #688

Closed
andymckay opened this Issue Sep 14, 2018 · 9 comments

Comments

Projects
None yet
7 participants
@andymckay
Copy link
Contributor

andymckay commented Sep 14, 2018

It would be nice to provide a deployments API in slack such that a command such as /github deploy would trigger the API.

https://developer.github.com/v3/repos/deployments/

Todo:

  • add in a bit more information about exactly which of the APIs we want to call
  • we should listen to the webhooks to inform slack about the status of deployments

@gimenete gimenete self-assigned this Sep 18, 2018

@bkeepers

This comment has been minimized.

Copy link
Contributor

bkeepers commented Sep 19, 2018

we should listen to the webhooks to inform slack about the status of deployments

Deployment status is already implemented, so it should just be a matter of triggering the deployment: https://github.com/integrations/slack/blob/master/lib/activity/index.js#L39

@gimenete

This comment has been minimized.

Copy link
Contributor

gimenete commented Sep 19, 2018

@gimenete gimenete referenced this issue Sep 26, 2018

Merged

Deployments #698

@judoole

This comment has been minimized.

Copy link

judoole commented Jan 3, 2019

Does this mean that /github deploy should start working now?

@gimenete

This comment has been minimized.

Copy link
Contributor

gimenete commented Jan 3, 2019

@judoole this is in the codebase but not enabled yet. We need to ask to upgrade permissions of the app in order to enable it so we are waiting to do the proper communication on why we need upgraded permissions, etc.

@judoole

This comment has been minimized.

Copy link

judoole commented Jan 4, 2019

Thanks for a quick answer and good work @gimenete!

@wushujames

This comment has been minimized.

Copy link

wushujames commented Jan 31, 2019

@gimenete , do you have an estimate for when /deploy will be enabled? It sounds like a really useful feature.

@assimovt

This comment has been minimized.

Copy link

assimovt commented Jan 31, 2019

@wushujames In the meantime, check out https://getslashdeploy.com It already provides /deploy with a bunch of other useful commands and it's built on top of GitHub deployment API - so works out of the box. I've built it to specifically uplift GH deployment workflows.

@torbjornvatn

This comment has been minimized.

Copy link

torbjornvatn commented Mar 6, 2019

@gimenete any news on when the deploy functionality will be enabled?

@gimenete

This comment has been minimized.

Copy link
Contributor

gimenete commented Mar 12, 2019

@torbjornvatn we are waiting on some changes that the team in charge of app permissions is going to do to, in order to make the permissions upgrade smoother. Sorry for the inconvenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.