This repository has been archived by the owner. It is now read-only.

All tests are green again #142

Closed
wants to merge 52 commits into
from

Conversation

Projects
None yet
4 participants
@glenngillen

I love the irony of the build being broken on a CI server :) Any chance you guys could merge this on?

henrypoydar and others added some commits Dec 15, 2009

Do not check intermediate build status when using threaded builder.
Threaded builder runs the build asynchronously. This means after
submitting a build the build's status may be not built yet, pending,
or potentially finished (succeeded/failed) depending on how long
the build process is and thread scheduling.

Using resque builder instead of threaded builder, with no builder
running, makes all statuses not built yet but obviously without
a running builder the tests don't complete successfully.

Comment out the intermediate build status checks until a more
predictable builder is developed.
Properly order builds started in the same second.
Order builds that started in the same second by descending id.

This removes one sleep call in manual build test, and makes
github test work under ruby 1.9 which I'm guessing is faster
than 1.8 and causes builds to be all created in the same second.
Bring redgreen require out of ruby-debug begin-rescue block.
On ruby 1.9, where ruby-debug does not exist, redgreen was
never be loaded. Now redgreen loading is independent of ruby-debug.
Fix do_sqlite3 dependency for ruby 1.9.3-preview1.
do_sqlite3 < 0.10.7 uses DateTime.new! which does not exist in
ruby 1.9.3-preview1 (it was removed somewhere in 1.9 line).
When running on 1.9, require 0.10.7.

For 1.8, 0.10.7 seems to work fine, at least in tests.
However due to massive amounts of spam generated by 0.10.5+
with datamapper 1.0.x, keep the version at 0.10.2 as it was
previously.
dm-sweatshop's master is no longer at 1.0.2, delete :git option as th…
…at breaks bundle install if gemfile.lock is deleted
Merge branches 'other-scm-doc', 'changes', 'list-archives-link', 'web…
…mock-reset', 'builder-test-fixes', 'dependency-cleanup' and 'build-without-commit-handling' into mine
Rework full message handling.
Use message + full_message, with message being a truncated
subject, instead of subject + body, because our message
is 255 characters long at most and datamapper migrations are
too painful.

full_message now contains the subject and body together.
@richmeyers

This comment has been minimized.

Show comment Hide comment
@richmeyers

richmeyers Nov 22, 2011

Contributor

Please test master now that my pull requests have been merged.

Contributor

richmeyers commented Nov 22, 2011

Please test master now that my pull requests have been merged.

@glenngillen

This comment has been minimized.

Show comment Hide comment
@glenngillen

glenngillen Nov 22, 2011

Thanks Rich. I noticed your fork after I issued this pull request and pulled most of it in myself. Nice work :)

Thanks Rich. I noticed your fork after I issued this pull request and pulled most of it in myself. Nice work :)

@richmeyers

This comment has been minimized.

Show comment Hide comment
@richmeyers

richmeyers Nov 22, 2011

Contributor

Your threading-related changes are interesting, I want to look at them more closely.

What is the reasoning behind glenngillen/integrity@db4d264 and similar edits?

Contributor

richmeyers commented Nov 22, 2011

Your threading-related changes are interesting, I want to look at them more closely.

What is the reasoning behind glenngillen/integrity@db4d264 and similar edits?

@glenngillen

This comment has been minimized.

Show comment Hide comment
@glenngillen

glenngillen Nov 22, 2011

The github acceptance test fails sporadically on my machine with 1.8.7. Haven't identified why this fixes it, suspect it might be a class accessor being overwritten somewhere by a setup block.

The github acceptance test fails sporadically on my machine with 1.8.7. Haven't identified why this fixes it, suspect it might be a class accessor being overwritten somewhere by a setup block.

@richmeyers

This comment has been minimized.

Show comment Hide comment
@richmeyers

richmeyers Nov 22, 2011

Contributor

Did you get color output working on ruby 1.9?

Contributor

richmeyers commented Nov 22, 2011

Did you get color output working on ruby 1.9?

@grahamc grahamc closed this Jan 4, 2012

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.