This repository has been archived by the owner. It is now read-only.

Artifacts #164

Closed
wants to merge 14 commits into
from

Conversation

Projects
None yet
3 participants
@richmeyers
Contributor

richmeyers commented Mar 5, 2012

This replaces #154.

Major changes:

  • Artifacts column length increased to 1000.
  • Artifacts are separated with semicolons, they have special meaning in the shell and are less likely to be used than commas both in unix and windows.
  • Expanded help text for artifacts.
  • More correctly escape and unescape artifact paths in urls.
  • Only serve artifacts that match configured artifact specifications.

@richmeyers richmeyers referenced this pull request Mar 5, 2012

Closed

Artifacts #154

Shaun and others added some commits Feb 2, 2012

removed debugging lines, cleaned to request a pull into integrity/int…
…egrity

fixed buried artifacts breaking the display of artifacts and reverted lib/integrity/payload_builder.rb to pre-me derping with it state.
moved the artifact logic into the rendering helper as #build_artifact…
…s, using %2F as the directory delimiter instead of ~, other small various things.
fixed issue where projects with ( ) in the name were not having their…
… literal project path used and artifacts were 404'ing
Set artifacts field length to 1000 chars.
It is very difficult to increase the length later,
set it to 1000 initially to be safe.
Reimplement artifact handling under builds.
Perform proper escaping of path components.

Sinatra treats %2F in urls as slashes and uses them to separate
path components. Escape artifact paths an extra time to work around this.

When retrieving artifacts, check that requested files are
in fact matched by one of the artifacts before serving them.
@richmeyers

This comment has been minimized.

Show comment Hide comment
@richmeyers

richmeyers May 18, 2012

Contributor

I have had this code running for a while now in our CI server, but we haven't actually used it.

My use case is nearly opposite from that of original submitter: when tests fail, I want to be able to access failure (exception) reports via integrity.

This means:

  1. Artifacts should be exposed regardless of build status, if they exist. Currently when a build fails artifacts are not exposed.
  2. Artifact wildcards are useful.
  3. If artifacts are specified via wildcards and none exist, no UI for them should be displayed. Currently there is an empty box for artifacts in my use case.
Contributor

richmeyers commented May 18, 2012

I have had this code running for a while now in our CI server, but we haven't actually used it.

My use case is nearly opposite from that of original submitter: when tests fail, I want to be able to access failure (exception) reports via integrity.

This means:

  1. Artifacts should be exposed regardless of build status, if they exist. Currently when a build fails artifacts are not exposed.
  2. Artifact wildcards are useful.
  3. If artifacts are specified via wildcards and none exist, no UI for them should be displayed. Currently there is an empty box for artifacts in my use case.
@grahamc

This comment has been minimized.

Show comment Hide comment
@grahamc

grahamc May 19, 2012

Member

@richmeyers I agree on all three points. I'm also interested in exposing an entire directory of artifacts.

Member

grahamc commented May 19, 2012

@richmeyers I agree on all three points. I'm also interested in exposing an entire directory of artifacts.

@p

This comment has been minimized.

Show comment Hide comment
@p

p Dec 5, 2012

Member
Member

p commented Dec 5, 2012

@p p closed this Dec 5, 2012

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.