Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Adds Flowdock notification support #232

Merged
merged 1 commit into from Apr 5, 2013

Conversation

Projects
None yet
2 participants
Contributor

jeremyw commented Apr 4, 2013

No description provided.

@p p and 1 other commented on an outdated diff Apr 4, 2013

lib/app/public/integrity.css
@@ -140,6 +140,7 @@ a {
margin-top: 1em;
margin-bottom: 0; }
#content form fieldset p.normal {
+ clear: both;
@p

p Apr 4, 2013

Member

This needs to be changed in https://github.com/integrity/integrity/blob/master/lib/app/views/integrity.sass and then integrity.css should be generated from integrity.sass.

Also, what does this change do?

@jeremyw

jeremyw Apr 4, 2013

Contributor

Ah, didn't notice the sass source.

This fixes a float issue when there's a long label. It was reproducible with the "From address (used for Gravatar)" label, where the following "Notify on success" paragraph was floating.

@p

p Apr 4, 2013

Member

Could you send a separate PR for it?

@jeremyw

jeremyw Apr 4, 2013

Contributor

It's in a separate commit now. Is that all right?

@p

p Apr 4, 2013

Member

Almost. You need to create a new branch off master, cherry pick the stylesheet commit into it and create a pull request for that branch. Then hard reset this branch to the first commit and force push.

Member

p commented Apr 4, 2013

Otherwise looks good, thanks!

Contributor

jeremyw commented Apr 4, 2013

Amended the commit to update the sass file. Thanks!

@p p added a commit that referenced this pull request Apr 5, 2013

@p p Merge pull request #232 from jeremyw/flowdock-notification
Adds Flowdock notification support
ea23b90

@p p merged commit ea23b90 into integrity:master Apr 5, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment