Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lavu/fifo: fix regression #500

Closed
wants to merge 1 commit into from

Conversation

xhaihao
Copy link
Collaborator

@xhaihao xhaihao commented Feb 8, 2022

offset_w might be updated after growing the FIFO

Fix ticket #9630

Signed-off-by: Haihao Xiang haihao.xiang@intel.com

offset_w might be updated after growing the FIFO

Fix ticket #9630

Signed-off-by: Haihao Xiang <haihao.xiang@intel.com>
@uartie
Copy link
Collaborator

uartie commented Feb 8, 2022

LGTM. This fixes it for me. Nice Job!

@uartie
Copy link
Collaborator

uartie commented Feb 8, 2022

Other test failures caused by https://trac.ffmpeg.org/ticket/9629... unrelated.

Copy link
Collaborator

@uartie uartie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@uartie
Copy link
Collaborator

uartie commented Feb 8, 2022

maybe change commit title to be less generic... e.g. "lavu/fifo: offset_w should capture FIFO growth"

@uartie
Copy link
Collaborator

uartie commented Feb 8, 2022

maybe change commit title to be less generic... e.g. "lavu/fifo: offset_w should capture FIFO growth"

No worries though since it is already submitted to ML.

@xhaihao
Copy link
Collaborator Author

xhaihao commented Feb 8, 2022

maybe change commit title to be less generic... e.g. "lavu/fifo: offset_w should capture FIFO growth"

Sorry I didn't see this comment when I submitted https://patchwork.ffmpeg.org/project/ffmpeg/patch/20220208054734.14166-1-haihao.xiang@intel.com/

@xhaihao xhaihao closed this Feb 8, 2022
@uartie
Copy link
Collaborator

uartie commented Feb 8, 2022

maybe change commit title to be less generic... e.g. "lavu/fifo: offset_w should capture FIFO growth"

Sorry I didn't see this comment when I submitted https://patchwork.ffmpeg.org/project/ffmpeg/patch/20220208054734.14166-1-haihao.xiang@intel.com/

no worries. lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants