recognize DMR, refactor to handle multiple Intel families #526
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors how CPU vendor and architecture constants are referenced throughout the codebase, centralizing them in the new
perfspect/internal/cpuspackage. It also updates all usages to use the new constants and moves certain CPU-related helper functions fromreporttocpus, improving maintainability and consistency.Key changes:
Centralization of CPU Vendor and Architecture Constants
perfspect/internal/cpuspackage and replaced hardcoded strings like"GenuineIntel","AuthenticAMD","x86_64", and"aarch64"with constants such ascpus.IntelVendor,cpus.AMDVendor,cpus.X86Architecture, andcpus.ARMArchitectureacross the codebase. [1] [2] [3]Refactoring of CPU Helper Functions
reportpackage to the newcpuspackage, updating all usages (e.g.,report.GetCPUByMicroArchitecture→cpus.GetCPUByMicroArchitecture,report.GetCPU→cpus.GetCPU). [1] [2] [3]Script and Metadata Configuration Updates
Improved Maintainability
Minor Script Definition Adjustments
MicroArchitecturesinstead ofModelswhere appropriate, further improving clarity.These changes collectively improve code clarity, reduce duplication, and make it easier to support new CPU types or architectures.