From 81ebc63d031a987962e5e5d0e7fc18813b73c8d7 Mon Sep 17 00:00:00 2001 From: Srikanth Ramakrishna Date: Thu, 25 Jul 2024 08:33:14 -0700 Subject: [PATCH 1/3] fix conda and doc bugs Signed-off-by: Srikanth Ramakrishna --- pytorch/Dockerfile | 2 +- pytorch/README.md | 3 --- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/pytorch/Dockerfile b/pytorch/Dockerfile index 4480c251e..ce34f1e36 100644 --- a/pytorch/Dockerfile +++ b/pytorch/Dockerfile @@ -204,7 +204,7 @@ WORKDIR /jupyter COPY jupyter-requirements.txt . RUN python -m pip install --no-cache-dir -r jupyter-requirements.txt -RUN if [ ! -d "$(which conda)" ]; then \ +RUN if $(which conda >/dev/null); then \ echo "conda activate idp" >> ~/.bashrc; \ fi diff --git a/pytorch/README.md b/pytorch/README.md index c2d1449de..d94070cfc 100644 --- a/pytorch/README.md +++ b/pytorch/README.md @@ -53,10 +53,8 @@ The images below additionally include [Jupyter Notebook](https://jupyter.org/) s ```bash docker run -it --rm \ -p 8888:8888 \ - --net=host \ --device /dev/dri \ -v /dev/dri/by-path:/dev/dri/by-path \ - --ipc=host \ intel/intel-extension-for-pytorch:2.1.20-xpu-pip-jupyter ``` @@ -93,7 +91,6 @@ The images below additionally include [Jupyter Notebook](https://jupyter.org/) s ```bash docker run -it --rm \ -p 8888:8888 \ - --net=host \ -v $PWD/workspace:/workspace \ -w /workspace \ intel/intel-extension-for-pytorch:2.3.0-pip-jupyter From d6652b363d02683b88110051e1cd40820f92b545 Mon Sep 17 00:00:00 2001 From: Srikanth Ramakrishna Date: Thu, 25 Jul 2024 08:49:14 -0700 Subject: [PATCH 2/3] try lint error fix Signed-off-by: Srikanth Ramakrishna --- pytorch/Dockerfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pytorch/Dockerfile b/pytorch/Dockerfile index ce34f1e36..80df9f38b 100644 --- a/pytorch/Dockerfile +++ b/pytorch/Dockerfile @@ -204,7 +204,7 @@ WORKDIR /jupyter COPY jupyter-requirements.txt . RUN python -m pip install --no-cache-dir -r jupyter-requirements.txt -RUN if $(which conda >/dev/null); then \ +RUN if $( which conda >/dev/null ); then \ echo "conda activate idp" >> ~/.bashrc; \ fi From 34312eb50c44092d305fc9fed8be1cc7a1afe80c Mon Sep 17 00:00:00 2001 From: Srikanth Ramakrishna Date: Thu, 25 Jul 2024 09:21:38 -0700 Subject: [PATCH 3/3] fix linting error Signed-off-by: Srikanth Ramakrishna --- pytorch/Dockerfile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pytorch/Dockerfile b/pytorch/Dockerfile index 80df9f38b..809da9c8b 100644 --- a/pytorch/Dockerfile +++ b/pytorch/Dockerfile @@ -204,8 +204,8 @@ WORKDIR /jupyter COPY jupyter-requirements.txt . RUN python -m pip install --no-cache-dir -r jupyter-requirements.txt -RUN if $( which conda >/dev/null ); then \ - echo "conda activate idp" >> ~/.bashrc; \ +RUN if eval "which conda >/dev/null )"; then \ + echo "conda activate idp" >> ~/.bashrc; \ fi COPY --chown=root notebooks/ipex-xpu.ipynb /jupyter/xpu.ipynb