🎨 Refactor flow builder #793
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem:
- The flow `service`s and `builder`s are too coupled to their implementations, viz:
- `flow::FunctionPtr` is used for both the interface function on the `service`
and the node type for the inlined function list; these have nothing to do
with each other.
- The `service` needs to know about the builder's interface.
- The `graph_builder` knows about details of inlining the function list.
- The `impl` is poorly named (it was named for the first, but now not the
only, implementation).
Solution:
- Inject the builders and implementations at the correct levels.
- Instead of passing through template arguments, expose names and interfaces
from lower levels. This enables concepts (TBD).
mjcaisse-intel
approved these changes
Nov 4, 2025
Contributor
mjcaisse-intel
left a comment
mjcaisse-intel
left a comment
There was a problem hiding this comment.
(praise) Really nice rework.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
services andbuilders are too coupled to their implementations, viz:flow::FunctionPtris used for both the interface function on theserviceand the node type for the inlined function list; these have nothing to do with each other.serviceneeds to know about the builder's interface.graph_builderknows about details of inlining the function list.implis poorly named (it was named for the first, but now not the only, implementation).Solution: