From 5c24b253bec3df156cba982b88b5d3ec1016618a Mon Sep 17 00:00:00 2001 From: Terri Oda Date: Tue, 30 Jan 2024 13:44:20 -0800 Subject: [PATCH 1/2] ci: Add python 3.12 with fix from @milinddethe15 Co-authored-by: milinddethe15 Signed-off-by: Terri Oda --- .github/workflows/testing.yml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/testing.yml b/.github/workflows/testing.yml index 3d8200895b..f66c6d697e 100644 --- a/.github/workflows/testing.yml +++ b/.github/workflows/testing.yml @@ -61,8 +61,7 @@ jobs: runs-on: ubuntu-22.04 strategy: matrix: - python: ['3.8', '3.9', '3.11'] - # python 3.12 throws aiohttp package install errors + python: ['3.8', '3.9', '3.11', '3.12'] timeout-minutes: 60 steps: - name: Harden Runner @@ -112,6 +111,9 @@ jobs: - name: Install cabextract if: env.sbom != 'true' run: sudo apt-get update && sudo apt-get install cabextract + - name: Install python3.12-dev to fix pip builds + if: ${{ matrix.python == '3.12' }} + run: sudo apt-get install python3.12-dev - name: Install OS dependencies for testing PDF if: env.sbom != 'true' run: sudo apt-get install build-essential libpoppler-cpp-dev pkg-config python3-dev From d62d7032cd4ab53898e6db30ff23326adae9724f Mon Sep 17 00:00:00 2001 From: Terri Oda Date: Tue, 30 Jan 2024 14:15:38 -0800 Subject: [PATCH 2/2] ci: remove package that doesn't work --- .github/workflows/testing.yml | 3 --- 1 file changed, 3 deletions(-) diff --git a/.github/workflows/testing.yml b/.github/workflows/testing.yml index f66c6d697e..0e54510ba6 100644 --- a/.github/workflows/testing.yml +++ b/.github/workflows/testing.yml @@ -111,9 +111,6 @@ jobs: - name: Install cabextract if: env.sbom != 'true' run: sudo apt-get update && sudo apt-get install cabextract - - name: Install python3.12-dev to fix pip builds - if: ${{ matrix.python == '3.12' }} - run: sudo apt-get install python3.12-dev - name: Install OS dependencies for testing PDF if: env.sbom != 'true' run: sudo apt-get install build-essential libpoppler-cpp-dev pkg-config python3-dev